search

Open-EO / openeo-python-client

Python client API for OpenEO
https://open-eo.github.io/openeo-python-client/
Apache License 2.0
156 stars 42 forks source link

open auth URL in new window #443

Closed dthiex closed 1 year ago

dthiex commented 1 year ago

Could we change the client that the Visit Link to authenticate would open in a new window. It's a bit annoying that when you want to open it to authenticate the browser tries to leave the notebook.

image

soxofaan commented 1 year ago

hmm, for me it already opens the link in a new tab (using jupyterlab 4.0.2 here) what notebook environment do you use?

soxofaan commented 1 year ago

anyway 2b8914c should do the trick I guess

dthiex commented 1 year ago

anyway https://github.com/Open-EO/openeo-python-client/commit/2b8914c4ff2394bffbb1ec25cb3f906076fa44a6 should do the trick I guess

Indeed works now, thanks! (I was on jupyter ==1.0.0 and notebook ==6.5.4 while testing this).