Open-EO / openeo-python-client

Python client API for OpenEO
https://open-eo.github.io/openeo-python-client/
Apache License 2.0
155 stars 42 forks source link

Add sen2like process #446

Open ValentinaHutter opened 1 year ago

ValentinaHutter commented 1 year ago

I wanted to ask, if it would be possible to add a .sen2like() to the openeo-python-client? The process would be used directly on a SENTINEL2_L1C datacube using data.sen2like(spatial_extent = ?bounding-box:object , temporal_extent = ?temporal-interval:array<string|null>, target_product = ?string, target_resolution = ?number, options = ?object) So, all of the parameters are optional.

The process definition can also be found under: https://github.com/eodcgmbh/openeo-processes/blob/master/sen2like.json

Thanks in advance!

soxofaan commented 1 year ago

It's an experimental, back-end specific process, bit shouldn't be too hard too add.

note that it is already possible to add this sen2like to your process graph without a dedicated DataCube method, using the generic way as explained in https://open-eo.github.io/openeo-python-client/processes.html#passing-data-cube-arguments, e.g.:

cube = cube.process(
    "sen2like", 
    data=cube,
    spatial_extent=...,
    temporal_extent=...,
    target_product=..., 
    target_resolution=....,
    options=...
)
soxofaan commented 1 year ago

just to set expectations right: it's unlikely we'll be able to address this issue soon as we're handling some higher prio issues with reduced work force (due to holidays), and there is already a generic workaround available

(PRs are welcome of course :smile: )

jdries commented 1 year ago

@ValentinaHutter does the generic way work for you? @VITO we also have some custom processes, but never add them to the python client as a dedicated method because they are not official ones.

soxofaan commented 1 year ago

side-note: we also have this feature idea of dynamically supporting processes: #40

LukeWeidenwalker commented 1 year ago

@ValentinaHutter is currently on holiday, so jumping in here!

Thanks for your comments both!

This was requested by @patrick-griffiths in our last chat as an improvement to user-friendliness of the sen2like processor - @patrick-griffiths could you please comment on whether this is still desirable in light of these comments?