Issue #259 Make pyproj an optional dependency when parsing CRS strin…

Open-EO / openeo-python-client

Python client API for OpenEO

https://open-eo.github.io/openeo-python-client/

Apache License 2.0

156 stars 42 forks source link

Issue #259 Make pyproj an optional dependency when parsing CRS strin… #458

Closed JohanKJSchreurs closed 1 year ago

JohanKJSchreurs commented 1 year ago

Issue #259 continued: Make pyproj an optional dependency when parsing CRS string / EPSG code

Now the import of pyproj happens locally in the function that needs it.
CRS values are only processed further with pyproj when they are neither type int nor a string that represents an integer.

soxofaan commented 1 year ago

thanks, merged already to get builds working again

(If necessary, I'll do some follow-ups directly on master)

soxofaan commented 1 year ago

did some refactoring in the end in b2a0e00ef9f61c75a91167328ded9a09f6a43522 (tagged this ticket wrong apparently). Biggest change is that the normalization function also can return a WKT2 CRS string (not only EPSG int), because that is also allowed in openEO API. This made it actually possible to simplify the function and rework the optional pyproj import stuff

soxofaan commented 1 year ago

pff that pyproj stuff is highly version sensitive. It took more commits that I anticipated to get things right. I should have worked in a feature branch in hindsight :stuck_out_tongue: