search

Open-EO / openeo-python-client

Python client API for OpenEO
https://open-eo.github.io/openeo-python-client/
Apache License 2.0
156 stars 42 forks source link

Eliminate `XarrayDataCube`? #472

Open soxofaan opened 1 year ago

soxofaan commented 1 year ago

XarrayDataCube is extremely simple: it just wraps a single xarray.DataArray and nothing more. It offers some IO functionality, but that doesn't mean these have to be XarrayDataCube methods. (There is also a plot method, but I wonder if anybody uses that and I dislike that this drags in a dependency on matplotlib)

It's simple, but it creates an extra abstraction layer in working with UDF, possibly making things more confusing than necessary.

can we just drop (the need for) XarrayDataCube ?

jdries commented 11 months ago

This is there on backend side, we will of course have to keep XArrayDataCube around for quite a bit. Next step is to update documentation to favour UDF's without XArrayDataCube in the signature.

soxofaan commented 10 months ago

Indeed, we have to keep XarrayDataCube for legacy reasons and backward compatibility. My questions/proposal is mainly about having a new, simpler UDF signature API