search

Open-EO / openeo-python-client

Python client API for OpenEO
https://open-eo.github.io/openeo-python-client/
Apache License 2.0
143 stars 36 forks source link

Issue527 load stac metadata #548

Closed VincentVerelst closed 3 months ago

VincentVerelst commented 3 months ago

@soxofaan , addressed all your initial comments.

clausmichele commented 1 month ago

@soxofaan @VincentVerelst I just seen this PR. The same functionality has been implemented by me here using the load_stac implementation: https://github.com/Open-EO/openeo-python-client/blob/d64fc30decfcf94860553f1b32027f5d1183099d/openeo/local/connection.py#L116

but it's quite slow since it's building the datacube view of the queried Collection to get the metadata. It would be good to align and get the metadata in the same way, I will look into how to port it to the LocalConnection.

Just a comment: I don't like that the "bands" dimension has an hardcoded "bands" label. As experienced during the openeo-test-suite, this information should come from the datacube extension if it's available (cube.dimensions ...) https://github.com/Open-EO/openeo-python-client/pull/548/files#diff-de2cebdb79abf5b65ca416029a8be7bed5e377d451383eef92cbec604d773122R583

soxofaan commented 1 month ago

@clausmichele indeed, this implementation is certainly open for further improvements and aligning. We just wanted to get some initial stuff in place to support some use cases