search

Open-EO / openeo-python-client

Python client API for OpenEO
https://open-eo.github.io/openeo-python-client/
Apache License 2.0
156 stars 42 forks source link

load_stac: get asset metadata from "item_assets" in collection instead of from items #553

Closed VictorVerhaert closed 5 months ago

VictorVerhaert commented 8 months ago

Right now asset metadata like band names are loaded from the nested items in a collection. Getting them directly from item_assets could improve performance.

This would also serve as a quick fix for https://github.com/Open-EO/openeo-geopyspark-driver/issues/460

soxofaan commented 8 months ago

are you referring here to https://github.com/Open-EO/openeo-python-client/blob/59655b8c16f468c751c4381a29e99674f58be344/openeo/metadata.py#L564-L576 in particular or is this about something else?

VictorVerhaert commented 8 months ago

Yeah initialy we were talking about the python driver, but this turned out to be useless as each items needs to be checked anyway.

@VincentVerelst mentioned that this could however improve performance for the python client for his use case (GFMap?) so this issue was transferred to the python client.

VincentVerelst commented 8 months ago

Indeed, in case that the item_asset extension in present in the STAC collection, we can read the band names from there and don't need to iterate over each item in the collection.

soxofaan commented 5 months ago

I think this is already covered by #577 (feel free to reopen if not)