search

Open-EO / openeo-python-driver

Common parts of a Python driver implementation for OpenEO
Apache License 2.0
11 stars 5 forks source link

atmospheric_correction: Use options instead of new parameters? #91

Open m-mohr opened 3 years ago

m-mohr commented 3 years ago

As requested the options parameter had been added to atmospheric_correction so that custom options could be exposed.

The custom options VITO exposes are added as new parameters directly, see https://openeo.vito.be/openeo/1.0/processes/backend/atmospheric_correction

Is it intentional that the implemented process does individual parameters instead of using the options parameter?

(Somewhat related question: What is the missionId useful for? Sounds like it should be read from metadata?)

m-mohr commented 3 years ago

EODC is also using the options since today.

soxofaan commented 3 years ago

FYI: I added options support to python client on EODC request: https://github.com/Open-EO/openeo-python-client/commit/1f02360c12441b0efe3c05070d67c5b845882817

m-mohr commented 3 years ago

Thanks. Are the options also available in ard_surface_reflectance?

soxofaan commented 3 years ago

ard_surface_reflectance in python client now also supports atmospheric_correction_options and cloud_detection_options : https://github.com/Open-EO/openeo-python-client/commit/9d372b941b0ee93e58f5ee3c8fd7badc923651b4