search

Open-EO / openeo-qgis-plugin

QGIS Plugin to connect and use openEO compliant backends.
Apache License 2.0
17 stars 1 forks source link

Integrate OpenEO-Hub into Plugin #17

Closed bgoesswe closed 4 years ago

bgoesswe commented 5 years ago

Get the available backends from the open-eo hub. Let the user choose from them. See: https://github.com/Open-EO/openeo-hub https://github.com/Open-EO/openeo-web-editor/issues/25

christophfriedrich commented 4 years ago

Was this closed because it's now implemented? :)

bgoesswe commented 4 years ago

Yes, we automatically read the version >0.4.0 compliant backends from the openeo-hub API ;-)

christophfriedrich commented 4 years ago

Cool! :slightly_smiling_face: :+1:

Now I found where it is in your code. What is this special handling for? Is it because the VITO entry is an object, not a string?

https://github.com/Open-EO/openeo-qgis-plugin/blob/dc6f860b9cbd285dc54fd67eb8b782ae339c3ff3/openeo_connector_dialog.py#L94

bgoesswe commented 4 years ago

Yes I thought this will be maybe replaced when VITO implements this ".well-known" URL, because I am not sure if this object can occur in general.

bgoesswe commented 4 years ago

Or is it some kind of standard that can also happen with other backends in the future ?

christophfriedrich commented 4 years ago

You're right, this will be replaced once VITO supports .well-known -- but it can occur in general.

A few days ago I added a documentation paragraph to the Hub's README that explains the format:

links to .well-known documents where available, otherwise a link directly to the backend OR an object with several links to backends of the same provider

This construct is allowed in case there is a provider that has multiple backends but doesn't support .well-known. I think that's not too likely to occur again -- but it may happen.

Another reason to change that if is that if the Hub's config would change (e.g. renaming "VITO GeoPySpark" to "VITO drivers") it wouldn't work anymore.

It would be better if that if would check all properties of the object for their type (string or object) and apply the special handling to all entries that were identified as objects.

bgoesswe commented 4 years ago

Yeah thats true, we will fix this :)