search

Open-EO / openeo-spring-driver

openEO driver build on spring using WCPS and ODC storage access
Apache License 2.0
0 stars 0 forks source link

version and provider hardcoded #60

Open clausmichele opened 2 years ago

clausmichele commented 2 years ago

Currently in the exposed metadata the version is hardcoded here: https://github.com/Open-EO/openeo-spring-driver/blob/4f469faaf7390ed1a1879971d99ef35b4a923f45/src/main/java/org/openeo/spring/api/CollectionsApiController.java#L797

and the provider has a default value here: https://github.com/Open-EO/openeo-spring-driver/blob/4f469faaf7390ed1a1879971d99ef35b4a923f45/src/main/java/org/openeo/spring/api/CollectionsApiController.java#L1800

I propose to remove the default hardcoded version and retrieve it from Rasdaman or ODC.

For the provider instead, we should firstly check if there is one available and if not, set the default one. Additionally, it seems that maximum 4 providers are allowed.

@aljacob what do you think about this limitation? Should we allow more than 4?

@pierocampa I tag you here just for your interest.

pierocampa commented 2 years ago

The version should keep the version of the collection, when specified.

The "Eurac EO WCS" "host (not the provider) should really be factored out to a configuration file. The provider, which is indeed better taken from the collection's metadata, is however not overwritten now by the server, so no need to act imho. Just the host' is.

As a final note: this ticket exposes a code duplication in the CollectionsApiController class, see describeCollection() and loadWcpsCollections() methods.

pierocampa commented 2 years ago

I also understand that having a version, requires to add a stac_extension:

This property REQUIRES to add version (STAC < 1.0.0-rc.1) or https://stac-extensions.github.io/version/v1.0.0/schema.json (STAC >= 1.0.0-rc.1) to the list of stac_extensions.

I would propose to keep this "v1" as default value in case an input collection does not specify a version, while not overwriting existing versioning. This means that stac_extensions will have to include version (as the currently implemented STAC version is 0.9.0 afaik).