Open-EO / openeo-spring-driver

openEO driver build on spring using WCPS and ODC storage access
Apache License 2.0
0 stars 0 forks source link

Allow processing extension in STAC Collection result #98

Closed clausmichele closed 4 days ago

clausmichele commented 3 weeks ago

Currently, if the returned STAC Collection (generated with raster2stac) returned from the openeo_odc_driver to the openeo-spring-driver include additional fields (like the processing extension: https://github.com/stac-extensions/processing) the spring driver crashes because it doesn't know how to handle those fields.

Sample result STAC from CDSE including processing extension: https://openeo.dataspace.copernicus.eu/openeo/1.2/jobs/j-240806b0429044aa975027bd02e9a226/results/NWFkOThhZjAtZDQ2ZS00MDk0LTg0Y2EtZGJjM2FlMjllNmE5/26aef1829bad9b896380dd73f63bac11?expires=1725009588

pierocampa commented 1 week ago

The link to the batch job result has expired. Please request the results again.

@clausmichele, can you refresh the link?

pierocampa commented 1 week ago

Anyway, are you adding the process graph's JSON definition as a processing:expression element? With which format?

Any other fields to be expected?

clausmichele commented 1 week ago

Here you can find a valid link: https://openeo.dataspace.copernicus.eu/openeo/1.2/jobs/j-240806b0429044aa975027bd02e9a226/results/NWFkOThhZjAtZDQ2ZS00MDk0LTg0Y2EtZGJjM2FlMjllNmE5/d60e33376f8ae035172f7e16c58561e8?expires=1725893530

pierocampa commented 1 week ago

ciao @clausmichele, the patch proposal is available in the feature/stac_results branch now.

If the result is as expected (I added a test case with the actual collection example you provided, so it should all be OK), let's merge this branch out.

Let me know!

pierocampa commented 1 week ago

PS see 6b99766a

clausmichele commented 6 days ago

I confirm that it works using the latest updates.

pierocampa commented 4 days ago

Ok, thank you @clausmichele, I will proceed with the merges to master of both ogc-testbed-19 and feature/stac_results.

pierocampa commented 4 days ago

Closing this issue: the test collection used to mark this as passed can be found here: stac_collection_processing.200.json