search

Open-EO / openeo-test-suite

Test suite for validation of openEO back-ends against the openEO API specification
Apache License 2.0
0 stars 2 forks source link

WP3 Validation of process metadata: test_process_metadata_functional() should ignore non-functional metadata in parameter schema #54

Open Jay-Gohil opened 3 months ago

Jay-Gohil commented 3 months ago

test_process_metadata_functions() from src/openeo_test_suite/tests/processes/metadata/test_process_metadata.py, check values within functional and non-functional parameters. For example, this function also tests for description, which is present in the schema parameter. Like "id": "array_append", "parameters": [ { "description": "Value to append to the array.", "name": "value", "schema": { "description": "Any data type is allowed." } } \ This should not happen if -m "not optional" is added to the command.

soxofaan commented 2 months ago

non-functional parameters are skipped with -m "not optional". The longrunning marker has nothing to do with process metadata.

See the docs in readme about "WP3 Validation of process metadata":

Non-functional tests concern descriptions and other metadata of processes that have no impact on the actual behavior of the process, failures in these tests should be taken as warnings, but don't necessarily need to be fixed. These can be skipped by adding -m "not optional" to the pytest command.

Jay-Gohil commented 2 months ago

There's was a mistake in last sentence. I have made the edit.

soxofaan commented 2 months ago

ok, I understand now, you are talking about non-functional fields in the schema of process parameters. The parameter's schema is indeed being compared as a whole currently:

https://github.com/Open-EO/openeo-test-suite/blob/5b9727d6b6b8a05672bcdd1aafd0a289f32a472a/src/openeo_test_suite/tests/processes/metadata/test_process_metadata.py#L79-L80

Do you have some concrete examples of differing parameter schema's?