search

Open-EO / openeo-web-editor

An interactive and easy to use web-based editor for the OpenEO API.
https://editor.openeo.org
Apache License 2.0
12 stars 17 forks source link

Datetime picker too large #126

Closed m-mohr closed 3 years ago

m-mohr commented 3 years ago

The datetime picker is too large, it adds like half of the size to the bundle.

The related issue and PR were never merged: https://github.com/chronotruck/vue-ctk-date-time-picker/pull/172 https://github.com/chronotruck/vue-ctk-date-time-picker/pull/164

An option could be to migrate to: https://element.eleme.io/#/en-US/component/datetime-picker#datetimepicker

clausmichele commented 3 years ago

Additionally, often I have to select the date twice to get a correct range, otherwise it reverts back to the current year and date with no selection. It's an annoying bug, especially when you have to select time spans in previous years

m-mohr commented 3 years ago

Yes, indeed. I've also seen this behavior and we'll try to get another solution in the next months.

m-mohr commented 3 years ago

Here's an alternative we could use: https://github.com/mengxiong10/vue2-datepicker It seems to fulfill all requirements, although the temporal chooser is not very intuitive...

clausmichele commented 3 years ago

It seems good to me, especially because you can also write the time range. Maybe you can show the different possibilities in the next dev talk.

m-mohr commented 3 years ago

Thanks. There's only this one and the old one, so I'll just try implement it. :-)

m-mohr commented 3 years ago

A new date/time picker has been implemented. How do you like it, @clausmichele ?

clausmichele commented 3 years ago

A new date/time picker has been implemented. How do you like it, @clausmichele ?

Nice, finally it works without double selection! But the default view is a code block for no selection, is this intentional? image

m-mohr commented 3 years ago

@clausmichele that was not the case for me, so is unintentional. Which process or collection is that?

clausmichele commented 3 years ago

It's load_collection on our Eurac back-end (all the collections) with the live web editor, version 0.7.2.

m-mohr commented 3 years ago

Hmm, I can't reproduce it. You just dragged and dropped load_collection into an empty model builder window and opened the options window? Which is the collection that has been preselected? Which browser are you using?

m-mohr commented 3 years ago

Okay, it's only happening for ADO_CORINE_100m_3035 for me... It's happening because the temporal extent is [null,null]. Will check.

clausmichele commented 3 years ago

Yes I've also checked better now, it happens only if the collection has no temporal extent. Apart from this it works fine on all the other cases!

m-mohr commented 3 years ago

Should be fixed in version 0.7.3, have just deployed it.