search

Open-EO / openeo-web-editor

An interactive and easy to use web-based editor for the OpenEO API.
https://editor.openeo.org
Apache License 2.0
12 stars 17 forks source link

Add help tour for ConnectForm (connecting to server and logging in) #199

Closed christophfriedrich closed 3 years ago

christophfriedrich commented 3 years ago

This PR adds a help button in the upper right corner of the "login bubble":

grafik

And the corresponding tour steps of course, see code or try for yourself :)

m-mohr commented 3 years ago

@christophfriedrich I should merge this tomorrow afternoon at the latest, can you finalize the PR until then? The 0.9.0 release should include this for SRR2 and thus I have to release Thu morning.

christophfriedrich commented 3 years ago

Yes I can finish it by then :ok_hand:

m-mohr commented 3 years ago

Is this ready to be merged? @christophfriedrich

christophfriedrich commented 3 years ago

The help text redesign is still missing, just a few more minutes :wink:

m-mohr commented 3 years ago

Take your time, I'll only merge tomorrow.

christophfriedrich commented 3 years ago

All conversations are now resolved, and I even managed to make tour steps for elements that aren't always there "on demand". Which was important, because otherwise when a server doesn't support ALL things that we would have explanations for, the tour would crash because the bubble's target isn't there.

In the same fashion, I guess we could also add the more fine-grained things that were requested in https://github.com/Open-EO/openeo-web-editor/pull/199#pullrequestreview-746074063.

The only issue I still encountered and can't really think of a way to fix: When a user is on the e.g. "Internal" tab, starts the tour, and then switches over to "No credentials", the tour crashes because the step for the input fields (login-credentials) was already loaded, but the target has since been removed from the DOM...

m-mohr commented 3 years ago

What does crash mean? Does it just stop the tour? And then a user would need to restart?

m-mohr commented 3 years ago

Yeah, so it stops. That's fine for now, but certainly something we should try to improve later. Merged, thanks!

christophfriedrich commented 3 years ago

Yes, it stops, just disappears. And I wasn't able to restart either. But I think it's an edge case, so yeah we can improve that later.

m-mohr commented 3 years ago

I was able to restart, but we should have an eye on it.