search

Open-EO / openeo-web-editor

An interactive and easy to use web-based editor for the OpenEO API.
https://editor.openeo.org
Apache License 2.0
12 stars 17 forks source link

Latest version and back-end compatibility (EURAC) #232

Closed clausmichele closed 2 years ago

clausmichele commented 2 years ago

Hi Matthias,

the latest version 0.10.1 returns an error when trying to connect to EURAC: image

Are there new constraints for being compatible? The 0.9.6 version works fine.

jdries commented 2 years ago

we discovered this one in the middle of a workshop! :-(

soxofaan commented 2 years ago

same issue here indeed with VITO backend (https://editor.openeo.org/?server=https%3A%2F%2Fopeneo.vito.be)

because I'm logged in with EGI, instead of that error message toast, I get an error in the popup:

Screenshot from 2022-01-13 10-46-40

(in private browsing mode, so no existing cookies, I get the error message toast as shown by @clausmichele )

soxofaan commented 2 years ago

I'm not sure, but the popup has an URL like https://aai.egi.eu/oidc/authorize?client_id=vito-default-client&redirect_uri=https%3A%2F%2Feditor.openeo.org&response_type=code&scope=openid%2Cemail%2Ceduperson_entitlement%2Ceduperson_scoped_affiliation%2Coffline_access&state=6ed...

the scope param is comma separated (%2C), while it should be space separated I think (%20)

soxofaan commented 2 years ago

from some local experimenting it seems the comma separated scope string is indeed the problem

soxofaan commented 2 years ago

This is probably the commit that changed it from space-separated to comma-separated: https://github.com/Open-EO/openeo-js-client/commit/6424d33183d93bc8654dd9a98a858edb3a1469ae#diff-a5e4b610c1dde3e4ca4c23c96048f9a52944c2209622044aac5606d2b969a291L227-R244

m-mohr commented 2 years ago

Sorry about that. Unfortunately, OIDC is not covered by tests due to its interactive nature. I'll issue a fix in the next 1-2 hours.

m-mohr commented 2 years ago

A fix has been issued and deployed. Sorry for any inconvenience caused.