search

Open-EO / openeo-web-editor

An interactive and easy to use web-based editor for the OpenEO API.
https://editor.openeo.org
Apache License 2.0
12 stars 17 forks source link

allow entering process graph without "process_graph" wrapper #271

Closed soxofaan closed 2 years ago

soxofaan commented 2 years ago

The code editor requires that the process graph JSON is wrapped in {"process_graph": ...} otherwise, when you try to switch to "visual mode", you get this "Process invalid" error:

Screenshot from 2022-08-11 14-56-34

Very often, when I do user support, the user shares their process graph without the {"process_graph": ...} wrapper. Can't we just support that format too in the editor?

m-mohr commented 2 years ago

It requires it because that's how it is specified, a process requires the "process_graph". The other variant is a left over in the other clients from the old 0.x days. So I'd rather say, please implement the other clients in a way that they don't export invalid processes any more:

So as this seems to bubble up again, I think https://github.com/Open-EO/openeo-python-client/issues/155 should be re-opened?

A related issue is probably that for example in https://discuss.eodc.eu/t/renaming-existing-bands-bugged/442 users post Python dict representations, that can't be imported in JS either.

Related improvement planned for the Editor: #269

soxofaan commented 2 years ago

Regarding re-opening https://github.com/Open-EO/openeo-python-client/issues/155 : I commented on that ticket itself. I also closed https://github.com/Open-EO/openeo-python-client/issues/209 as a duplicate of that.