search

Open-Historical-Map-Labs / openhistoricaltiles

First iteration of vector tiles from OHM Planet data
BSD 2-Clause "Simplified" License
3 stars 0 forks source link

Clean up BlackRockCity dates #17

Closed jeffreyameyer closed 6 years ago

jeffreyameyer commented 6 years ago

Make the red go away here: https://openhistoricalmap.github.io/openhistoricaltiles/dateerrors/#15/40.7747/-119.2160

jeffreyameyer commented 6 years ago

I think we're all good here. @gregallensworth or @danrademacher - want to QA?

danrademacher commented 6 years ago

If the style is working, we're in good shape!

image

@jeffreyameyer can you post a link to the changeset?

gregallensworth commented 6 years ago

I also panned over to Seattle, and confirmed that those items are still red and orange. So this is no fluke.

Not only did you clean up the dates, but the changes propagated into vtiles and through it, becoming visible into web maps, including client-side filtering in web maps. This is everything we could have hoped for.

jeffreyameyer commented 6 years ago

Ha! There are a bunch... the database server is a bit slow, so editing using JOSM is more of a pain than I'd like... I can post, but it'll be a set...

On Mon, Aug 27, 2018 at 10:38 AM, Dan Rademacher notifications@github.com wrote:

If the style is working, we're in good shape!

[image: image] https://user-images.githubusercontent.com/1423200/44675376-3a913580-a9e5-11e8-88c4-d555914597ad.png

@jeffreyameyer https://github.com/jeffreyameyer can you post a link to the changeset?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenHistoricalMap/openhistoricaltiles/issues/17#issuecomment-416305996, or mute the thread https://github.com/notifications/unsubscribe-auth/ABbOElw6BHFlv-YGmXb44Ey1qJt_RGVkks5uVC6KgaJpZM4WIY-M .

-- Jeff Meyer 206-676-2347 osm: Open Historical Map (OHM) http://wiki.openstreetmap.org/wiki/Open_Historical_Map / my OSM user page http://www.openstreetmap.org/user/jeffmeyer t: @OpenHistMap

jeffreyameyer commented 6 years ago

Suh-weet!!!

On Tue, Aug 28, 2018 at 10:28 AM, Greg Allensworth <notifications@github.com

wrote:

I also panned over to Seattle, and confirmed that those items are still red and orange. So this is no fluke.

Not only did you clean up the dates, but the changes propagated into vtiles and through it, becoming visible into web maps, including client-side filtering in web maps. This is everything we could have hoped for.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenHistoricalMap/openhistoricaltiles/issues/17#issuecomment-416672515, or mute the thread https://github.com/notifications/unsubscribe-auth/ABbOEmiFT8Csp-naG9XfrTVL7Pn16Eplks5uVX24gaJpZM4WIY-M .

-- Jeff Meyer 206-676-2347 osm: Open Historical Map (OHM) http://wiki.openstreetmap.org/wiki/Open_Historical_Map / my OSM user page http://www.openstreetmap.org/user/jeffmeyer t: @OpenHistMap