Closed danrademacher closed 6 years ago
I have a working prototype up, and it's pretty cool: https://openhistoricalmap.github.io/openhistoricaltiles/datefilter/#14.16/40.77635/-119.21658/
There are two clear date periods where all content fits:
Still some refinements I'd like to make to the UI:
The URL has now uses a date component as well: https://openhistoricalmap.github.io/openhistoricaltiles/datefilter/#14.16/40.77626/-119.21650/2008-01-01,2008-12-31/ https://openhistoricalmap.github.io/openhistoricaltiles/datefilter/#14.16/40.77643/-119.21527/2009-01-01,2009-12-31/ https://openhistoricalmap.github.io/openhistoricaltiles/datefilter/#14.16/40.77643/-119.21527/2008-01-01,2009-12-31/
This means that the prior URL which lacks a date, will no longer zoom to the region as it is now missing required parameters.
This is awesome!!
I love what's enabled by the URL time elements, will this have any impacts on other URL-based methods for accessing tiles? e.g. many tools count on the zoom/lat/long method, even though we're going to have to put start_date and end_date in there somewhere. This is AWESOME!
On Tue, Sep 4, 2018 at 2:36 PM, Greg Allensworth notifications@github.com wrote:
The URL has now uses a date component as well: http://localhost:9000/#14.16/40.77626/-119.21650/2008-01-01,2008-12-31/ http://localhost:9000/#14.16/40.77643/-119.21527/2009-01-01,2009-12-31/
This means that the prior URL which lacks a date, will no longer zoom to the region as it is now missing required parameters.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OpenHistoricalMap/openhistoricaltiles/issues/20#issuecomment-418526085, or mute the thread https://github.com/notifications/unsubscribe-auth/ABbOEqA51m7z-CGrcv8U7a5Y6tX9qeUaks5uXvJFgaJpZM4WUWYW .
-- Jeff Meyer 206-676-2347 osm: Open Historical Map (OHM) http://wiki.openstreetmap.org/wiki/Open_Historical_Map / my OSM user page http://www.openstreetmap.org/user/jeffmeyer t: @OpenHistMap
Quoting @jeffreyameyer "will this have any impacts on other URL-based methods for accessing tiles?"
No; the URL of individual PBF tiles has not changed in any way. The URL params are provided so the application may configure itself e.g. pan and zoom the map, enable or disable some controls or UI elements, etc. and is not at all related to the URLs used to fetch vector tile data.
muy bueno!
On Tue, Sep 4, 2018 at 3:35 PM, Greg Allensworth notifications@github.com wrote:
Quoting @jeffreyameyer https://github.com/jeffreyameyer "will this have any impacts on other URL-based methods for accessing tiles?"
No; the URL of individual PBF tiles has not changed in any way. The URL params are provided so the application may configure itself e.g. pan and zoom the map, enable or disable some controls or UI elements, etc. and is not at all related to the URLs used to fetch vector tile data.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenHistoricalMap/openhistoricaltiles/issues/20#issuecomment-418539845, or mute the thread https://github.com/notifications/unsubscribe-auth/ABbOEu7dtgLK-uUAbDP2JpXIUel7xl9lks5uXwBLgaJpZM4WUWYW .
-- Jeff Meyer 206-676-2347 osm: Open Historical Map (OHM) http://wiki.openstreetmap.org/wiki/Open_Historical_Map / my OSM user page http://www.openstreetmap.org/user/jeffmeyer t: @OpenHistMap
Another test condition, and explanation of behavior:
The dashed line to the northeast is 198180475 Southern Border UK disupted territory and has proper start and end dates, so ong as your date filters include a period between 1783-09-03 and 1842-08-09.
Not visible on the map is 198180496 Maine-Canada border, which has a start date of 1783-09-03 but lacks an end date and so is invalid.
This is exactly as expected.
Black Rock City is our test case: https://openhistoricalmap.github.io/openhistoricaltiles/dateissues/#15.00/40.77470/-119.21600/
This should work for filters that can separate 2008 and 2009.
Allow user to select
start_date
andend_date
.-01-01
to start and-12-31
to endI'm still a little foggy on how exactly these filters work in MBGL. So there might be discussion needed and expansion of this into multiple issues.