search

Open-Historical-Map-Labs / openhistoricaltiles

First iteration of vector tiles from OHM Planet data
BSD 2-Clause "Simplified" License
3 stars 0 forks source link

No data for 2018-2019 ? #41

Closed gregallensworth closed 5 years ago

gregallensworth commented 5 years ago

New York City, 2017. Move time forward into 2018 or 2019, and there's suddenly nothing visible.

http://localhost:9000/demo/#14.600/40.80623/-73.91894/2017,0-2019

https://openhistoricalmap.github.io/openhistoricaltiles/mbgl-control-timeslider/demo/#14.629/40.81577/-73.91392/2017,0-2019

May be a data issue, may be a computer bug, may be a hole in our whole logic for how to think of date filtering. Figure out what, so we can plan next steps.

gregallensworth commented 5 years ago

First note: Data issues. These buildings have explicit end dates of 2018-11-01 Therefore it is correct that they vanish in 2019. But shouldn't they persist through 2018?

image

Also, notice the orange features in the map. These all have a blank starting date, and an end date of 2018-11-10 We never did define the expected behavior for items which have a start and no end, or an end but no start. Maybe best to treat "" as the beginning/end of time, e.g. "prehistory through 1923" or "since 1776 through present date"

gregallensworth commented 5 years ago

49a3867 Filtering adjusted, so "" values are start/end of time ("prehistory", "current date and expected future")

This brings in several features which have a blank start date, and therefore had previously been missed:

image

Of course, this also means that these features are now displayed back into prehistory, such as in this screenshot from the year 100 CE:

image

gregallensworth commented 5 years ago

5bfbce6 adjusts the filtering logic to include features which started/ended within the selected calendar year. Thus, those buildings in NYC will show when 2018 is selected, as they did have a presence during some part of 2018.

jeffreyameyer commented 5 years ago

Could be a data issue. I'll fix any underlying data. Would be better if we could figure out an approach / wildcard for "current day / present"

On Wed, May 1, 2019, 10:47 PM Greg Allensworth notifications@github.com wrote:

New York City, 2017. Move time forward into 2018 or 2019, and there's suddenly nothing visible.

http://localhost:9000/demo/#14.600/40.80623/-73.91894/2017,0-2019

https://openhistoricalmap.github.io/openhistoricaltiles/mbgl-control-timeslider/demo/#14.629/40.81577/-73.91392/2017,0-2019

May be a data issue, may be a computer bug, may be a hole in our whole logic for how to think of date filtering. Figure out what, so we can plan next steps.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OpenHistoricalMap/openhistoricaltiles/issues/41, or mute the thread https://github.com/notifications/unsubscribe-auth/AALM4EWZE6HL34LA7LFHHS3PTH6VRANCNFSM4HJX4JCQ .