search

Open-Historical-Map-Labs / openhistoricaltiles

First iteration of vector tiles from OHM Planet data
BSD 2-Clause "Simplified" License
3 stars 0 forks source link

set up and test editing in Maputnik #61

Closed danrademacher closed 4 years ago

danrademacher commented 5 years ago

I copied the map style used in the live staging site and converted from JS to JSON hre: https://raw.githubusercontent.com/OpenHistoricalMap/openhistoricaltiles/gh-pages/ohm_timeslider_style/ohm.style.json (commit with notes is here)

And then tested opening that in Maputnik editor both via the URL above and direct file upload. Both seem to work fine: image

This seems like a good approach to editing and testing outside of the Rails app and code base -- edit in Maputnik, commit changes to local GH Pages, push changes to GH, and others on the dev team can preview inside Maputnik by loading from the URL above.

I am less confident that we want to constantly push changes here and have them show up instantly on the staging site. Having this as a design and iteration space, then we push over to staging is a better approach. Though we want to make that push as easy as possible.

┆Created By: Dan Rademacher

danrademacher commented 4 years ago

Maputnik process going over to Tim pending another issue I'm about to file about scoping out a fuler cartography pass

tsinn commented 4 years ago

First draft ready to implement, I believe! image

danrademacher commented 4 years ago

@tsinn can you commit changes to the style JSON to this repo?

jeffreyameyer commented 4 years ago

Sweet!

On Tue, Oct 15, 2019 at 2:54 PM Dan Rademacher notifications@github.com wrote:

@tsinn https://github.com/tsinn can you commit changes to the style JSON to this repo?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OpenHistoricalMap/openhistoricaltiles/issues/61?email_source=notifications&email_token=AALM4EWCMQAVYMP4LDG3HULQOY3YJA5CNFSM4IVBPWXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBKLCZA#issuecomment-542421348, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALM4EVY75AY5Z2D2AW2FRDQOY3YJANCNFSM4IVBPWXA .

-- Jeff Meyer 206-676-2347 osm: Open Historical Map (OHM) http://wiki.openstreetmap.org/wiki/Open_Historical_Map / my OSM user page http://www.openstreetmap.org/user/jeffmeyer t: @OpenHistMap