Test revised map style in Leaflet timeslider demo

[danrademacher]

Over in #61 and #58 Tim has done an overall styling pass using these files: https://github.com/OpenHistoricalMap/openhistoricaltiles/tree/gh-pages/ohm_timeslider_style

Ideally, we'd figure out a way that the style could be dynamically referenced directly here, so that future updates are available to view in the demo: https://openhistoricalmap.github.io/openhistoricaltiles/ohm_timeslider_style/ohm.style.json

I see we're including the map style as a JS file here: https://github.com/OpenHistoricalMap/openhistoricaltiles/blob/gh-pages/leaflet-control-mbgltimeslider/demo/mapstyle.js

Not sure what the tradeoffs are of the JS with variables like SPRITE_URL_ROOT getting replaced with a full static JSON. Seems like if we get quicker style updates, that might be worth some stuff being hard-coded.

[gregallensworth]

This is now in place.

https://openhistoricalmap.github.io/openhistoricaltiles/leaflet-control-mbgltimeslider/demo/ is now loading from the style at https://openhistoricalmap.github.io/openhistoricaltiles/ohm_timeslider_style/ohm.style.json This is live/dynamic, so pushing changes to that file will "update" this demo as well.

However, note that the sprite file is not loading correctly. Please modify https://openhistoricalmap.github.io/openhistoricaltiles/ohm_timeslider_style/ohm.style.json such that the sprite definition does not include the .json suffix.

[jeffreyameyer]

I love that it's live at github.io... how does that move to here: http://openhistoricalmap-1936150974.us-east-1.elb.amazonaws.com/#map=16/49.5482/17.7354&layers=O ?

On Fri, Oct 18, 2019 at 3:05 PM Greg Allensworth notifications@github.com wrote:

This is now in place.

https://openhistoricalmap.github.io/openhistoricaltiles/leaflet-control-mbgltimeslider/demo/ is now loading from the style at https://openhistoricalmap.github.io/openhistoricaltiles/ohm_timeslider_style/ohm.style.json This is live/dynamic, so pushing changes to that file will "update" this demo as well.

However, note that the sprite file is not loading correctly. Please modify https://openhistoricalmap.github.io/openhistoricaltiles/ohm_timeslider_style/ohm.style.json such that the sprite definition does not include the .json suffix.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OpenHistoricalMap/openhistoricaltiles/issues/65?email_source=notifications&email_token=AALM4EULTJFUHQDJFC266FLQPIXIZA5CNFSM4JCMEQY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBWF6BA#issuecomment-543973124, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALM4EQ7BT6TGUHJUPMRPVDQPIXIZANCNFSM4JCMEQYQ .

-- Jeff Meyer 206-676-2347 osm: Open Historical Map (OHM) http://wiki.openstreetmap.org/wiki/Open_Historical_Map / my OSM user page http://www.openstreetmap.org/user/jeffmeyer t: @OpenHistMap

[jeffreyameyer]

Any reason that site fails with rendering at certain zooms in certain areas?

https://openhistoricalmap.github.io/openhistoricaltiles/leaflet-control-mbgltimeslider/demo/#10.000/50.30908/2.59661/1920,-4000-2018

On Fri, Oct 18, 2019 at 7:26 PM Jeff Meyer jeff@gwhat.org wrote:

I love that it's live at github.io... how does that move to here: http://openhistoricalmap-1936150974.us-east-1.elb.amazonaws.com/#map=16/49.5482/17.7354&layers=O ?

On Fri, Oct 18, 2019 at 3:05 PM Greg Allensworth notifications@github.com wrote:

This is now in place.

https://openhistoricalmap.github.io/openhistoricaltiles/leaflet-control-mbgltimeslider/demo/ is now loading from the style at https://openhistoricalmap.github.io/openhistoricaltiles/ohm_timeslider_style/ohm.style.json This is live/dynamic, so pushing changes to that file will "update" this demo as well.

However, note that the sprite file is not loading correctly. Please modify https://openhistoricalmap.github.io/openhistoricaltiles/ohm_timeslider_style/ohm.style.json such that the sprite definition does not include the .json suffix.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OpenHistoricalMap/openhistoricaltiles/issues/65?email_source=notifications&email_token=AALM4EULTJFUHQDJFC266FLQPIXIZA5CNFSM4JCMEQY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBWF6BA#issuecomment-543973124, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALM4EQ7BT6TGUHJUPMRPVDQPIXIZANCNFSM4JCMEQYQ .

-- Jeff Meyer 206-676-2347 osm: Open Historical Map (OHM) http://wiki.openstreetmap.org/wiki/Open_Historical_Map / my OSM user page http://www.openstreetmap.org/user/jeffmeyer t: @OpenHistMap

-- Jeff Meyer 206-676-2347 osm: Open Historical Map (OHM) http://wiki.openstreetmap.org/wiki/Open_Historical_Map / my OSM user page http://www.openstreetmap.org/user/jeffmeyer t: @OpenHistMap

[danrademacher]

Hmm that area Jeff saw as a problem seems to be only when zoom is >=10 This works: https://openhistoricalmap.github.io/openhistoricaltiles/leaflet-control-mbgltimeslider/demo/#9.000/50.31039/2.59689/1920,1900-2018

this doesn't: https://openhistoricalmap.github.io/openhistoricaltiles/leaflet-control-mbgltimeslider/demo/#10.000/50.31039/2.59758/1920,1900-2018

[jeffreyameyer]

Yep, sorry... should have included that info about the zoom level.

On Tue, Oct 22, 2019 at 2:22 PM Dan Rademacher notifications@github.com wrote:

Hmm that area Jeff saw as a problem seems to be only when zoom is >=10 This works:

https://openhistoricalmap.github.io/openhistoricaltiles/leaflet-control-mbgltimeslider/demo/#9.000/50.31039/2.59689/1920,1900-2018

this doesn't:

https://openhistoricalmap.github.io/openhistoricaltiles/leaflet-control-mbgltimeslider/demo/#10.000/50.31039/2.59758/1920,1900-2018

[image: Xc8F12W44m] https://user-images.githubusercontent.com/1423200/67305486-3e65fe00-f4aa-11e9-9281-e94e8cf496bb.gif

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/OpenHistoricalMap/openhistoricaltiles/issues/65?email_source=notifications&email_token=AALM4ESTQD2C725A4J2YM6TQP5VKJA5CNFSM4JCMEQY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB7ICUQ#issuecomment-545161554, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALM4EXNNXQ5EUH6BECPHN3QP5VKJANCNFSM4JCMEQYQ .

-- Jeff Meyer 206-676-2347 osm: Open Historical Map (OHM) http://wiki.openstreetmap.org/wiki/Open_Historical_Map / my OSM user page http://www.openstreetmap.org/user/jeffmeyer t: @OpenHistMap

[danrademacher]

Interesting. I wasn't seeing 404s like I would expect if say we just hadn't rendered tiles at that zoom level. I wonder if instead there's just no styles defined for some of those elements beyond z9. The base style, OSM Bright, does seem rather focused on lower-number zooms

[danrademacher]

going to split this into a new issue