Open-Historical-Map-Labs / openhistoricaltiles

First iteration of vector tiles from OHM Planet data
BSD 2-Clause "Simplified" License
3 stars 0 forks source link

review rendering issues >z9 #66

Closed danrademacher closed 4 years ago

danrademacher commented 4 years ago

Pulled from #65 area Jeff saw as a problem seems to be only when zoom is >=10 This works: https://openhistoricalmap.github.io/openhistoricaltiles/leaflet-control-mbgltimeslider/demo/#9.000/50.31039/2.59689/1920,1900-2018

this doesn't: https://openhistoricalmap.github.io/openhistoricaltiles/leaflet-control-mbgltimeslider/demo/#10.000/50.31039/2.59758/1920,1900-2018

Xc8F12W44m

Looking closer, it appears to be some issue with maptiles missing, though at first I thought it might be gaps in our stylesheet (like z levels inadvertently left out), but that doesn't appear to be the case as here: image

Hmm, I wonder if this is a persisting issue with the sprite, though @tsinn pushed some fixes for that. Errors in console related to sprite and FontAwesome, image

danrademacher commented 4 years ago

@tsinn can you take a look at this? Might need Gregor's help, but first wondering if you can verify that the sprite is working or not working, so we can isolate that if it is the source of these errors.

tsinn commented 4 years ago

Thanks for the pointing to the errors in the Console. This led me to the answer. Villages were given a label text font of Noto Sans which is not available in the application. Changing to Noto Sans Regular which is available, fixed the rendering problems.