search

Open-MSS / MSS

A QT application, a OGC web map server, a collaboration server to plan atmospheric research flights.
https://open-mss.github.io
Apache License 2.0
63 stars 87 forks source link

Importing a fligh-track into MSCOlab does not update the versions in the version history automatically #1860

Open joernu76 opened 1 year ago

joernu76 commented 1 year ago

After importing a flight track, it was not updated to MSColab. Changing a table view longitude coordinate updated then the full plan to the server.

Desired behaviour: After import, a new version should be generated immediately.

ReimarBauer commented 1 year ago

@joernu76 I can't reproduce, I created a devel category and tried there on the devel1 OP.

ReimarBauer commented 1 year ago

Please provide more details

Refresh on the version history shows the updates

example_ftml_import.webm

joernu76 commented 1 year ago

OK, I had a closer look. The Version Window - in contrast to other View windows - is not automatically updated. This is surprising and thus not Pythonic. :-) Manually refreshing helps indeed. Is there a design reason for this?

ReimarBauer commented 1 year ago

The default is to look on named versions, you need to toggle to All versions too.

To get this updated it requires to implement a handler which act on 'file-changed' (because any user can update), signal_reload.

It was not implemented because it does make on many edits the table flicker.

When implemented that functionality should be covered by a test too.

joernu76 commented 1 year ago

If there is a good reason against this update, no worries. But the current situation is confusing. We updated a file to something veery similar and had the apparently bad idea to have a look into the Version History if the import worked as intented instead of looking at the TableView, which would have worked? I am not sure how this is a performance problem. In particular if the VersionHistory is not open it should not have an effect?

However, I requalify this as a feature request.