search

Open-MSS / MSS

A QT application, a OGC web map server, a collaboration server to plan atmospheric research flights.
https://open-mss.github.io
Apache License 2.0
59 stars 74 forks source link

Narrow the matching of the saml metadata route #2077

Open matrss opened 11 months ago

matrss commented 11 months ago

https://github.com/Open-MSS/MSS/blob/f6b3ad110dbfaa12d439cadea6476dcd54d9328d/mslib/mscolab/server.py#L857 This route could also be defined in a loop for each IdP (similar to the acs_post_handler), so that it does not match too broadly. That would remove the requirement for an explicit 404 (and the need for the entire 404 template).

_Originally posted by @matrss in https://github.com/Open-MSS/MSS/pull/2069#discussion_r1384900138_

matrss commented 11 months ago

Even better, use the (very sparsely documented) any route converter. That way, the function can stay as is and only the route matching string has to be modified.

References: