search

Open-MSS / MSS

A QT application, a OGC web map server, a collaboration server to plan atmospheric research flights.
https://open-mss.github.io
Apache License 2.0
54 stars 68 forks source link

feat: New UI for option in topview & sideview #2407

Open rohit2p opened 2 weeks ago

rohit2p commented 2 weeks ago

Purpose of PR?:

This PR contain new UI for option in topview & sideview with more features.

Checklist:

ReimarBauer commented 2 weeks ago

The PathPlotter needs to have your new options now. https://github.com/Open-MSS/MSS/blob/develop/mslib/msui/mpl_pathinteractor.py#L324

rohit2p commented 1 week ago

@ReimarBauer @joernu76 can you take a look plz, does it seems good? can i move on to the next thing?

ReimarBauer commented 1 week ago

@rohit2p the remote sensing bug will be fixed soon but the flake8 is yours

rohit2p commented 1 week ago

@ReimarBauer @joernu76 can you take a look i am implemented line thickness, transparency of lines, dashed lines option in topview option they are working but the problem is the value is getting stored in settings but when i restart the application the map plot doesn't reload according to the saved value in settings.

can you suggest me something how can fix this also does my implementation looks correct to you?

joernu76 commented 6 days ago

I just tried out your UI_element_in_option branch. Should it work, currently?

ReimarBauer commented 2 days ago

First try

Fatal error in MSS 9.0.0 on Linux-6.5.0-10040-tuxedo-x86_64-with-glibc2.35
Python 3.11.6 | packaged by conda-forge | (main, Oct  3 2023, 10:40:35) [GCC 12.3.0]

Please report bugs in MSS to https://github.com/Open-MSS/MSS

Information about the fatal error:

Traceback (most recent call last):
  File "/home/user/PycharmProjects/2024/rohit2p/MSS/mslib/msui/msui_mainwindow.py", line 895, in create_view_handler
    self.create_view(_type, self.active_flight_track)
  File "/home/user/PycharmProjects/2024/rohit2p/MSS/mslib/msui/msui_mainwindow.py", line 913, in create_view
    view_window = topview.MSUITopViewWindow(mainwindow=self, model=model,
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/user/PycharmProjects/2024/rohit2p/MSS/mslib/msui/topview.py", line 243, in __init__
    self.setup_top_view()
  File "/home/user/PycharmProjects/2024/rohit2p/MSS/mslib/msui/topview.py", line 331, in setup_top_view
    self.setFlightTrackModel(self.waypoints_model)
  File "/home/user/PycharmProjects/2024/rohit2p/MSS/mslib/msui/viewwindows.py", line 253, in setFlightTrackModel
    self.mpl.canvas.set_waypoints_model(model)
  File "/home/user/PycharmProjects/2024/rohit2p/MSS/mslib/msui/mpl_qtwidget.py", line 1543, in set_waypoints_model
    self.set_settings(None)
  File "/home/user/PycharmProjects/2024/rohit2p/MSS/mslib/msui/mpl_qtwidget.py", line 1670, in set_settings
    wpi_plotter.set_line_thickness(settings["line_thickness"])
                                   ~~~~~~~~^^^^^^^^^^^^^^^^^^
KeyError: 'line_thickness'
ReimarBauer commented 2 days ago

When I open Topview or Sideview I get

https://github.com/Open-MSS/MSS/assets/278728/09b166d6-4162-4a2b-933d-da9faacab49c