search

Open-Markets-Initiative / wireshark-lua

Source generated cross platform Wireshark dissectors
GNU General Public License v3.0
188 stars 63 forks source link

Add Quote Cancel Ack-Specific NumProcessedEntries Field #17

Closed Tzadiko closed 4 years ago

Tzadiko commented 4 years ago

This is in reference to my previous pull request.

Commit ae3b376 fixed Quote Cancel, but Quote Cancel Ack is still broken. The generator is not generating the correct NumProcessedEntries field for Quote Cancel Ack.

This field should be 4 bytes but it's borrowing Mass Quote Ack's 1 byte NumProcessedEntries.

This is a temporary fix.

QuoteCancelAck <field name="NoProcessedEntries" id="9772" type="uInt32" description="Number of quotes successfully cancelled (if in response to a Quote Cancel message)" offset="333" semanticType="int"/>

MassQuoteAck <field name="NoProcessedEntries" id="9772" type="uInt8" description="Number of quotes that have been accepted from the corresponding inbound message" offset="335" semanticType="int"/>

Open-Markets-Initiative commented 4 years ago

I am going to include this one but longer term either the CME should not reuse the names or the generator needs to figure out a way to rename based on type. Thanks again.

Tzadiko commented 4 years ago

Cool, I emailed CME and got a generic response about how their committees spend months on these changes. Looks like this slipped through a meeting or two.