search

Open-Markets-Initiative / wireshark-lua

Source generated cross platform Wireshark dissectors
GNU General Public License v3.0
180 stars 64 forks source link

Typo in "Orig Ci Ord Id" #20

Closed gburca closed 4 years ago

gburca commented 4 years ago

The Cme.Futures.iLink3.Sbe.v8.5.Script.Dissector.lua dissects a field as Orig Ci Ord Id. That should be instead Orig Cl Ord Id. The field is defined around line 206 as:

cme_futures_ilink3_sbe_v8_5.fields.orig_ci_ord_id = ProtoField.new("Orig Ci Ord Id", "cme.futures.ilink3.sbe.v8.5.origciordid", ftypes.STRING)

The name probably comes from the upstream XML which has the correct name in the description but a typo in the field name:

<field name="OrigCIOrdID" id="41" type="String20Req" description="Contains the ClOrd of the cancelled order" ...

Open-Markets-Initiative commented 4 years ago

We added the ability to change protocol elements outside of the exchange xmls. Been meaning to do that for a while. Please check out: https://github.com/Open-Markets-Initiative/wireshark-lua/commit/7cb0dc9dd336be0ace709eebd4100133248577ea