search

Open-Markets-Initiative / wireshark-lua

Source generated cross platform Wireshark dissectors
GNU General Public License v3.0
184 stars 63 forks source link

JNX protocols throw errors when the "Show Payload" preference is enabled #47

Open chutzimir opened 1 year ago

chutzimir commented 1 year ago

The JNX OUCH protocol dissector throws an error when the "Show Payload" preference is enabled.

E.g., when show payload is on:

[Lua Error: ...plugins\Jnx.Equities.Pts.Ouch.v1.11.Script.Dissector.lua:2369: attempt to call field 'unsequenced_data_packet' (a nil value)]

or 

[Lua Error: ...plugins\Jnx.Equities.Pts.Ouch.v1.11.Script.Dissector.lua:2361: attempt to call field 'sequenced_data_packet' (a nil value)]

Indeed, the dissector does not define size_of.unsequenced_data_packet or size_of.sequenced_data_packet.

This is understanable, since sequenced and unsequenced packets do not have a fixed size, as the size differs based on the message type they carry.

Open-Markets-Initiative commented 1 year ago

We will take a look. I think its a likely a general issue with this case of struct. There is special code for parsing runtime sized structs and the wireshark preferences have not been updated to reflect that.