Open-Minds-Lab / mrQA

mrQA: tools for quality assurance in medical imaging datasets, including protocol compliance
https://open-minds-lab.github.io/mrQA/
Apache License 2.0
9 stars 6 forks source link

Sub-class modality #10

Open sinhaharsh opened 2 years ago

sinhaharsh commented 2 years ago

Inherit modality class to create multi-echo modalities and normal modalities, will have to change code for compliance accordingly

raamana commented 2 years ago

Good idea! also, this interacts with the need to modularize the methods for checking compliance (beyond simple numerical equality of values).. this needs to be attached to parameter themselves, from a set of known methods.. so when two compatible parameters are compared, we invoke the attached methods and not do an IF condition etc