Make a Figma design for the valve popup

aott33 commented 4 months ago

I think the DMC library popup is a good starting point. Below are a couple examples (Solenoid Valve and Analog Valve):

ArnaudDeClerck commented 4 months ago

My idea was to make a popup more like PlantPAX with a modern look. This is what i started

Flowject commented 4 months ago

Design wise I think both DMC and PlantPAX are, well, not the prettiest.

I'd definitely work with tabs to offer more functionality on the platforms that support it, some things that come to mind:

basic controls (as in DMC)
settings (such as timeout times)
active alarms
alarm history
trending (for 2 position I'm thinking state changes, optional of course)
the ability for the operator to make a note (and show note icon on the faceplate if it's the case), especially useful in combination with manual mode visualization to rely information across shift operators.

Doesn't all have to be there from day 1 of course, but shouldn't be that much work either. Let's first discuss what to include in https://github.com/Open-Mobile-Robotics/open-process-library/issues/2

Maybe for later but an option for custom extra tabs and fields? For example in an ISA88 batch controlled system I like it when I can see in the CM popup which phase is controlling my equipment (if exclusive use), but shouldn't be part of this library at least at this point.

I'll try to make some mockups in the next week as well.

zantiu commented 4 months ago

I think there's two things to consider:

what data/actions to put on the popup
what design style/layout

For the latter maybe get some inspiration of other projects. Not necessarily process automation.

One thing to for sure consider is the OpenBridge project: https://www.openbridge.no/

They already put a big effort in the design. Maybe we should even consider to align with it if it makes sense. https://www.openbridge.no/

zantiu commented 4 months ago

An example of how they do the popups: (notice that they already considered touch-operation from the start)

They have been active on the SASE Slack. And I remember they mentioned they also were thinking of working on a process library.

zantiu commented 4 months ago

I will reach out to OpenBridge.

zantiu commented 4 months ago

While browsing the OpenBridge conversations I came accross this link you shared @Flowject :

https://www.youtube.com/watch?v=6w8lW19s2y0&t=247s

Just an example but everything in the video is worth watching. Also the faceplates and other UI.

Flowject commented 4 months ago

Yeah I love Nader's work!

A bit 'busy' for my liking that one, but a great example, definitely one of the best implementations I've ever seen. I even send a link to that video to customers/prospects to show what Ignition can do as a SCADA system.

tibnor commented 4 months ago

Hi I'm currently implementing the IAS component in OpenBridge. Her is an example of a modal https://openbridge-storybook--pr189-demo-ais-esxofii4.web.app/?path=/story/automation-inputmodal--compact

It would be great if we could work together on this!

durinwinter commented 4 months ago

We definitely should. I love this!

Open-Mobile-Robotics / open-process-library

Make a Figma design for the valve popup #4