search

Open-NET-Libraries / Open.ChannelExtensions

A set of extensions for optimizing/simplifying System.Threading.Channels usage.
https://open-net-libraries.github.io/Open.ChannelExtensions/api/Open.ChannelExtensions.Extensions.html#methods
MIT License
401 stars 25 forks source link

README - comment for Join example #42

Closed tmenier closed 2 months ago

tmenier commented 2 months ago

I found "Join" to be a tad confusing for something that basically unbundles collections. Your other references to Linq equivalents are helpful, so I thought this might be helpful here. Thanks!

electricessence commented 2 months ago

I like where you're head is at here, but I'm worried that it could be confusing? It's less an analog for .SelectMany() and more closely related to DataFlow batching and joining. I'll reconsider adding more clarity around what .Join does.

electricessence commented 2 months ago

I made some more updates to the Readme in the master branch. Thanks for the feedback. :)

tmenier commented 2 months ago

Great additions, added some much needed clarity!

electricessence commented 2 months ago

Thanks for caring and chiming in with your ideas. :)