Open-Network-Models-and-Interfaces-ONMI / TAPI

LF ONMI Transport API Repository (TAPI)
https://github.com/Open-Network-Models-and-Interfaces-ONMI/TAPI/wiki
Apache License 2.0
95 stars 80 forks source link

Missing UUID in SIP list in get-service-interface-point-list RPC #372

Closed Andrea-Campanella closed 5 years ago

Andrea-Campanella commented 5 years ago

Currently there is no key in the list of tapi-common@2018-10-16.yang, so "get-service-interface-point-list" can only return one SIP. Example [Command] odtn@odtn-VirtualBox:~/onos/apps/odtn/service/src/test/resources$ curl -Ssl --user onos:rocks --noproxy localhost -X POST -H 'cache-control: no-cache' -H 'content-type: application/json' http://localhost:8181/onos/restconf/operations/tapi-common:get-service-interface-point-list -d @get-service-interface-point-list.json

[Source code] https://github.com/opennetworkinglab/onos/blob/master/apps/odtn/service/src/main/java/org/onosproject/odtn/internal/DcsBasedTapiCommonRpc.java#L69

Possibile solution change tapi-common@2018-10-16.yang as follows, and all SIPs were returned. https://github.com/opennetworkinglab/onos/blob/master/models/tapi/src/main/yang/tapi-common%402018-10-16.yang

653 rpc get-service-interface-point-list { 654 description "none"; 655 output { 656 list sip { +            key 'uuid'; 657 uses service-interface-point; 658 description "none"; 659 } 660 } 661 }