LLDP Modeling added to the TapiOam model

Open-Network-Models-and-Interfaces-ONMI / TAPI

LF ONMI Transport API Repository (TAPI)

https://github.com/Open-Network-Models-and-Interfaces-ONMI/TAPI/wiki

Apache License 2.0

95 stars 80 forks source link

LLDP Modeling added to the TapiOam model #387

Closed bzeuner closed 5 years ago

bzeuner commented 5 years ago

LLDP as defined in https://github.com/YangModels/yang/blob/master/standard/ieee/802.1/draft/ieee802-dot1ab-lldp.yang revision 2018-11-11

Additional comments:

ModelLibrary ImplementationCommonDataTypes added
Reference stereotype need to be suppressed in front of attributes (update of style sheet)
Bit typed attributes cannot be modelled because of old profiles
name attribute of Port not modeled (is using localId)
ZeroBasedCounter32 and Counter32 modelled by profile properties (bitLength = LENGTH_32_BIT, counter = ZERO_COUNTER/COUNTER); i.e., type could be changed to Integer
Modeling of Binary typed attributes to be discussed
readOnly attribute property just set to show in diagrams; already defined by property writeAllowed = WRITE_NOT_ALLOWED

bzeuner commented 5 years ago

Sorry, I gave the old link; here the new one: https://github.com/YangModels/yang/blob/master/standard/ieee/draft/802.1/ieee802-dot1ab-lldp.yang

No TAPI class have been modified; I have just augmented (specify) TAPI classes as shown in the agreed proposal 3 (see 2019-01-15 TAPI Meeting Notes).

bzeuner commented 5 years ago

The LLDP part of the TapiOam model has been updated based on the decisions taken at the TAPI conference call on February 12 (second commit to this pull request.

Changes:

Primitive types MacAddress, Binary and Timeticks added to TapiCommon and
then referenced in TapiOam
ModelLibrary ImplementationCommonDataTypes removed from TapiOam
Multiplicity of RemoteSystemsData corrected to [*]
YANG path statements added for information (to be removed finally)
YANG must statement added for information (to be removed finally)

The Bits-typed data types SystemCapabilitiesMap and TlvsTxEnable have to be updated once TAPI has moved to the latest Profiles.

greenshot

bzeuner commented 5 years ago

It has been decided to define the LLDP functionality in a separate Papyrus model -> TapiLldp. Therefore, this pull request will be replaced by a new one.