search

Open-Network-Models-and-Interfaces-ONMI / TAPI

LF ONMI Transport API Repository (TAPI)
https://github.com/Open-Network-Models-and-Interfaces-ONMI/TAPI/wiki
Apache License 2.0
95 stars 80 forks source link

Develop v2 1 #486

Closed amazzini closed 4 years ago

arthurMll commented 4 years ago

I have reviewed the .yang .tree files and it seems they do not match. I think the tree files are generated wrong or based in an intermediate version of the YANG files.

amazzini commented 4 years ago

Also renamed

nigel-r-davis commented 4 years ago

I have just reviewed the photonic media model and yang and have found another name issue following the OtsiAConnect... pattern. There is an OtsiGServerAdaptationPac. This comes out as otsi-gserver.... It ought to be otsig-server..., hence the uml should be OtsigServerAdaptationPac. There are also two forms, Otsia... and OtsiAssembly... in the uml. The OtsiAssemblyConnectionEndPointSpec... ought to be OtsiaConnectionEndPointSpec.

Unfortunately we also have an longhand media-channel-assembly-spec - this may be arguable because we are using longhand media-channel everywhere else not mc, so the distinction between OTSI and MC is set in general.

I suggest we stay with media-channel-assembly, but ought to fix the Otsig issue (as it is exactly the same pattern as the Otsia issue we have already fixed. We could consider the OtsiAssembly issue from a consistency perspective, but I am ok to leave it as is.

nigel-r-davis commented 4 years ago

Have just realized that the two items I commented on are both deprecated.

I have no issue with the PhotonicMedia model as it is.