Open-Network-Models-and-Interfaces-ONMI / TAPI

LF ONMI Transport API Repository (TAPI)
https://github.com/Open-Network-Models-and-Interfaces-ONMI/TAPI/wiki
Apache License 2.0
95 stars 80 forks source link

Stream changes #523

Closed nigel-r-davis closed 2 years ago

nigel-r-davis commented 2 years ago

Changes in the pull request are detailed below (constructed from a diff between current develop branch and this pull request)

GENERAL CHANGES Corrected comments in, or added comments to, classes, attributes and data types.

<> stereotype removed from all entities.

General improvements to diagram structure/layout.

Corrections to CONDTIONAL_MANDATORY from MANDATORY along with addition of a condition for many attributes that are 0..x. Defaults added to many attributes to assist in construction of condition statements.

Correction of wordings of CONDITIONAL_MANDATORY statements normalized to “Mandatory where…”.

General correction from RW –-> R and correction to many stereotypes to WRITE_NOT_ALLOWED (which was broadly inconsistent with Read Only statement).

RPCs removed

MANDATORY --> CONDITIONAL_MANDATORY (OR OPTIONAL) (CLASSES AND DATATYPES) The following lists attributes in classes/datatypes which are CONDITIONAL_MANDATORY and provides the condition statement “Mandatory where…”

AlarmConditionDetectorDetail (Deprecated)

AvailableStream

CompactedLogDetails

ConditionDetector

ConnectionProtocolDetails

DynamicStreamData (from StreamMonitor and then adjusted)

LogRecord

LogRecordBody

LogRecordHeader

SupportedStreamType

ApproxDateAndTime

LegacyProperties

OTHER CHANGES

AvailableStream

ConnectionProtocolDetails

LogRecordHeader

StreamAdminContext

StreamContext

StreamMonitor

SupportedStreamType

NEW ATTRIBUTES

CompactedLogDetails

ConnectionProtocolDetails

SupportedStreamType

NEW CLASSES

DynamicStreamData collecting attributes from StreamMonitor

InformationRecordStrategy including new attributes

NEW RELATIONSHIPS

StreamMonitorHasDynamicStreamData

AugmentWithInformationRecordDetails

FIXED RELATIONSHIPS

AlarmConditionDetectorDetailAugmentsConditionDetector

DELETED RELATIONSHIPS

InterfaceRealizationCompactedLogStream (and corresponding RPC)

InterfaceRealizationStream (and corresponding RPC)

ENUMERATIONS (AND LITERALS)

ConditionDetectorType has new literal PM_THRESHOLD_DETECTOR

ConnectionProtocol has been added

EncodingFormat has been added

RecordSuppression has been added

RecordTrigger has been added

ValueExpectation has been added

ValueExpectationDither has been added

LogRecordStrategy has been adjusted such that

RecordType has been extended to include CHANGE, UPDATE, CREATE and INFORMATION.

nigel-r-davis commented 2 years ago

Lost streaming change history due to the most recent equipment pull request history (streaming files did not change in that pull request but there were apparently history conflicts). Had to copy changed files from stream branch in my fork to equipment branch in my fork. All changes have been documented above on mass (carried out a diff of gendoc documents created for the original uml and the modified uml). https://github.com/OpenNetworkingFoundation/TAPI/pull/522 (closed) provides the detailed flow of changes if relevant.