search

Open-Network-Models-and-Interfaces-ONMI / onmi-iisomi-xhaul-uml-yang

5G xHaul PoC Applications
Apache License 2.0
30 stars 39 forks source link

Container vs List #17

Closed demx8as6 closed 5 years ago

demx8as6 commented 7 years ago

Michael discovered that the co-channel-group is now just a yang container, but was a yang list before.

demx8as6 commented 7 years ago

The comparsion of list and container statements between 3rd PoC and 4th PoC showed that there is only this one difference.

image

demx8as6 commented 7 years ago

Proposed modification:

demx8as6@controller:~/temp/CENTENNIAL/models/yang$ git diff microwave-model.yang
diff --git a/models/yang/microwave-model.yang b/models/yang/microwave-model.yang
index 719347f..86970eb 100644
--- a/models/yang/microwave-model.yang
+++ b/models/yang/microwave-model.yang
@@ -26,5 +26,5 @@ module microwave-model {
     description "This module contains a collection of YANG definitions for managing wireless networks.";
-    revision 2017-03-20 {
+    revision 2017-03-24 {
         description "Initial version";
         reference "ONF TR 532: A YANG Data Model for Wireless Networks.";
     }
@@ -1332,7 +1332,12 @@ module microwave-model {
                 }
                 description "Aggregated performance information of the air interface for a pre-defined measurement interval.";
             }
-            container co-channel-group {
+            list co-channel-group {
+                key 'co-channel-group-id';
+                uses co-channel-group-g;
+                description "none";
+            }
+            grouping co-channel-group-g {
                 leaf co-channel-group-id {
                     type core-model:universal-id;
                     description "none";
demx8as6@controller:~/temp/CENTENNIAL/models/yang$
demx8as6 commented 7 years ago

@pezou: I added you to the contributors - please comment as well - many thanks!

olinchy commented 7 years ago

What would you want me to do, keep it as group or restore it to list?

I haven't changed that yang model since the beginning of poc3, please let me know what do you have in mind and I will do it.

Best regards Liu

Sent from my iPhone

On 26 Mar 2017, at 8:09 PM, Martin Skorupski notifications@github.com wrote:

Assigned #17 to @olinchy.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

pezou commented 7 years ago

@demx8as6 it's fine for me , I have not implemented co-channel-group yet.

demx8as6 commented 5 years ago

fixed - with microwave-model@2019-03-23.yang