Open-Orange-Button / Orange-Button-Taxonomy

OpenAPI Orange Button taxonomy
https://Open-Orange-Button.github.io/Orange-Button-Taxonomy
Apache License 2.0
14 stars 19 forks source link

Adds StandardTypeItemType and adds updated Enums #180

Closed kevinkirkl3y closed 1 year ago

kevinkirkl3y commented 1 year ago

Closes #172

blizita commented 1 year ago

Note to talk through NEC690 as an example of overlapping standard

reepoi commented 1 year ago

The StandardTypeItemType enums plus the CertificationTypeProductItemType enums cover all of the standard name/number values from the CEC data. Should we include all the enums from CertificationTypeProductItemType in the enums of StandardTypeItemType? UL1741SA is a value from the CEC data that is in CertificationTypeProductItemType, but not in StandardTypeItemType.

Also, for grid support solar inverters, the CEC lists whether a product was tested according to a range of sections of a standard. For example, UL 1741 SA8-SA13. To communicate that a product is certified under this range, one option is to add an enum for each section (UL1741SA8,...,UL1741SA13) to StandardTypeItemType, and then create a ProdCertification for each of the sections.

kevinkirkl3y commented 1 year ago

@reepoi I have added UL1741SA to the StandardTypeItemType Enums. In reference to the individual section that are noted, there is the element CertificationTypeSections within the taxonomy and designed to serve this specific purpose. It currently isn't a member of any objects but could quickly be added ProdCertification if it meets your requirements.

reepoi commented 1 year ago

@kevinkirkl3y I have the list of the remaining enums to add to the StandardTypeItemType:

Also, I saw that the CEC does not use UL 1741 SA Section 16, so we could skip adding that section enum for now.

kevinkirkl3y commented 1 year ago

@reepoi , I have added the requested UL 1703, UL 9450 and JA12 Standards

cwhanse commented 1 year ago

@kevinkirkl3y to discuss: