Closed okerekechinweotito closed 2 years ago
Name | Link |
---|---|
Latest commit | f5728940338c87182c3ce2033d834696e9ca89c7 |
Latest deploy log | https://app.netlify.com/sites/oscsa-en-blog/deploys/63462401973f0a0009298c85 |
Deploy Preview | https://deploy-preview-11--oscsa-en-blog.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
@alswajiab Can you review this PR, if possible?
Thank you @okerekechinweotito for the detailed PR! I will merge to test is it's working!
@all-contributors add @okerekechinweotito for infrastructure
@BatoolMM
I've put up a pull request to add @okerekechinweotito! :tada:
@BatoolMM I would like to know if the Github-Action workflow works as expected when you trigger it. Is the deploy-preview now working ?. Pls let me know so that I can decide whether to look for further solutions. Thank you
Summary
This PR Fixes #8 #28 and #29 Related PRs at #31 and #30
❔ I refactored the code on ./github/workflows and I changed the file name in ./github/workflows to correctly reflect the instructions on Quarto Documentation
List of changes proposed in this PR (pull-request)
The current code is written as
I Refactored the code to
This is inline with this Github Netlify-Action Extension Example and Github Action Docs
What should a reviewer concentrate their feedback on?
‼️ Please Note , The changes made here cannot be tested through the deploy-preview. We can only know if it actually works after it has been merged and the new configurations sent to Netlify and integrated into the main branch. ✅ Go through the linked Documentations to confirm my claims. ✅ Confirm that the file name in ./github/workflows/workflows does not correspond with the instructions on the Quarto Documentation ✅ Confirm that the refactor recommendations on Github Netlify-Action Extension Example and Github Action Docs is indeed valid. ✅ After Merging , make a PR to test if the deploy-preview is now working
@BatoolMM @alswajiab