search

Open-Science-Community-Saudi-Arabia / OSCSA-en-blog

OSCSA English blog
https://oscsa-en-blog.netlify.app/
2 stars 15 forks source link

Added google translate to make the page multilingual #12

Open victorvictoria-maker opened 2 years ago

victorvictoria-maker commented 2 years ago

Contributed by making the page multilingual. Not sure we are to create another HTML file but wouldn't suggest that since the content on the page won't be static.

netlify[bot] commented 2 years ago

Deploy Preview for oscsa-en-blog ready!

Name Link
Latest commit e11211a83ead8104f7a454a986514096db28e9a0
Latest deploy log https://app.netlify.com/sites/oscsa-en-blog/deploys/63468f950908b20009f6bc5d
Deploy Preview https://deploy-preview-12--oscsa-en-blog.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Njong392 commented 2 years ago

:thinking: is there a way to set 'rtl' on this? @victorvictoria-maker so that when the user switches to languages like Persian, hebrew, or Arabic, let the content be from right to left?

Another thought. What if you narrowed the languages down to only English and Arabic? Because I see that @BatoolMM mentioned something about 'bilingual'.

Mublin commented 2 years ago

🤔 is there a way to set 'rtl' on this? @victorvictoria-maker so that when the user switches to languages like Persian, hebrew, or Arabic, let the content be from right to left?

Another thought. What if you narrowed the languages down to only English and Arabic? Because I see that @BatoolMM mentioned something about 'bilingual'.

Im making it bilingual soon but I don’t think it’s the right way to do it

Njong392 commented 2 years ago

thinking is there a way to set 'rtl' on this? @victorvictoria-maker so that when the user switches to languages like Persian, hebrew, or Arabic, let the content be from right to left? Another thought. What if you narrowed the languages down to only English and Arabic? Because I see that @BatoolMM mentioned something about 'bilingual'.

Im making it bilingual soon but I don’t think it’s the right way to do it

When @BatoolMM said bilingual, I figured it would only be English and Arabic.

BatoolMM commented 2 years ago

Yes, we wold like to have bilingual website, you can see a link to an Arabic blog here.

Can you also rebase this PR, please?

Njong392 commented 2 years ago

Yes, we wold like to have bilingual website, you can see a link to an Arabic blog here.

Can you also rebase this PR, please?

This link seems to be broken @BatoolMM

BatoolMM commented 2 years ago

@Njong392, the link is working now!

BatoolMM commented 2 years ago

@victorvictoria-maker Thank you, can you also rebase this PR, please?

victorvictoria-maker commented 2 years ago

@victorvictoria-maker Thank you, can you also rebase this PR, please?

I just saw this. Would work on that. Thanks

victorvictoria-maker commented 2 years ago

@victorvictoria-maker Thank you, can you also rebase this PR, please?

@BatoolMM Thank you mentor. I rebased it already. Please, merge. Thank you.