search

Open-Science-Community-Saudi-Arabia / OSCSA-en-blog

OSCSA English blog
https://oscsa-en-blog.netlify.app/
2 stars 15 forks source link

added aria-labels, removed inline css, updated style.css #20

Closed vanithaak closed 2 years ago

vanithaak commented 2 years ago

Summary Improved web accessibilty

List of changes proposed in this PR (pull-request)

  1. added aria-labels, in required places and changed a HTML tag (also indentation)
  2. removed inline css and added them to style.css

I also wanted to add a back-to-top button in the website, am I allowed to do that? or should I make a first-time-issue @BatoolMM

netlify[bot] commented 2 years ago

Deploy Preview for oscsa-en-blog ready!

Name Link
Latest commit 665dee6d4cb0fe08fc4e445c1a9253e0a4499186
Latest deploy log https://app.netlify.com/sites/oscsa-en-blog/deploys/634914b45562210008b2bf6f
Deploy Preview https://deploy-preview-20--oscsa-en-blog.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

BatoolMM commented 2 years ago

Thank you @vanithaak for your wonderful contribution!

Can you resolve the conflict and rebase the PR, please? If you would like to add new changes, please create a new issue and PR!

vanithaak commented 2 years ago

@BatoolMM I never rebased a PR but, I did something. Can you please check

BatoolMM commented 2 years ago

Hi @vanithaak, thank you for your hard work. This blog is based on Quarto, so we the HTML files are generated from quarto files and we aren't supposed to change any of the HTML files because they'll be overwritten again. All files in _site shouldn't be changed.

I am very sorry that this wasn't clear, you have worked very hard with fixing tags and inline CSS.

okerekechinweotito commented 2 years ago

@BatoolMM I see you triggered the Github-Action workflow. Is the deploy-preview now working ?. Pls let me know so that I can decide whether to look for further solutions

vanithaak commented 2 years ago

Hi @vanithaak, thank you for your hard work. This blog is based on Quarto, so we the HTML files are generated from quarto files and we aren't supposed to change any of the HTML files because they'll be overwritten again. All files in _site shouldn't be changed.

I am very sorry that this wasn't clear, you have worked very hard with fixing tags and inline CSS.

No worries , I'll work on other issues!

BatoolMM commented 2 years ago

@okerekechinweotito I tagged you in https://github.com/Open-Science-Community-Saudi-Arabia/OSCSA-en-blog/pull/25#issuecomment-1279699083.

I will close this PR for now but feel free to re-open it later. Thank you again @vanithaak for your work!