[17/10/2022]: TASK 5 - Deploy Preview ( CI /CD ) Discussion Thread

Open-Science-Community-Saudi-Arabia / OSCSA-en-blog

OSCSA English blog

https://oscsa-en-blog.netlify.app/

2 stars 15 forks source link

[17/10/2022]: TASK 5 - Deploy Preview ( CI /CD ) Discussion Thread #26

Closed okerekechinweotito closed 2 years ago

okerekechinweotito commented 2 years ago

Previous issue opened for TASK 5 is at #8 Previous PR opened for TASK 5 is at #11

I made the above issue and corresponding PR some days ago to fix the Netlify deploy preview. Unfortunately the changes I made there did not fix the issue. However , I have made a stunning discovery

After days of careful research I discovered that the PR deploy-preview is not working simply because the Quarto Publish does not yet support PR deploy-previews . The deploy-preview will not work with Quarto as the feature is still in development and has not yet been integrated into Quarto Publish. Here is a link to an OPEN issue on Quarto's Repo to support my claims. Support netlify PR previews in publish action

The above issue was opened by Quarto to create a feature that would address the exact problem we are trying to fix (Netlify Deploy Preview)

In conclusion , this issue cannot be fixed at the moment until Quarto adds support for it as stated here

@alswajiab @BatoolMM

okerekechinweotito commented 2 years ago

@alswajiab @BatoolMM
Please I need feedback on the above , Thanks

BatoolMM commented 2 years ago

Thank you for doing all this research, can you suggest other solutions to preview the page?

jesutobi commented 2 years ago

@okerekechinweotito can i join you on this issue,i am a frontend developer, where are you at the moment

okerekechinweotito commented 2 years ago

@BatoolMM I will look into it

okerekechinweotito commented 2 years ago

@BatoolMM @alswajiab Screenshot (57)

Inline with the proposed solutions on the image

(1) I could try using quarto netlify plug-in as described in the docs ( I cannot guarantee it will work)
(2) There is another option for any PR author to first run Quarto render locally ( Build App into _site folder) and then deploy with the generated output. ( might make messy diffs but it works , you would be able to see the changes on deploy-preview).
(3) I could try to incorporate this Netlify Deploy Action into our already existing Quarto Render/Publish action ( I cannot guarantee it will work )

Should we go ahead with option 2. Or should I first try option 1 and Option 3

BatoolMM commented 2 years ago

I want to point out that this uses Quarto https://github.com/ropensci/dev_guide/blob/main/.github/workflows/pr.yml which was pointed out by Maëlle Salmon. Can you have a look at it @okerekechinweotito, thanks again!

okerekechinweotito commented 2 years ago

The Deploy Preview is now working. I just tested it with a new PR here #34 . Kindly view the deploy-preview on that PR to confirm.

The changes to look for on the test PR is as follows - I changed all the blog titles to the sentence "I made this change in the Test PR , the deploy preview is now working"

The PRs that solved this are #30 and #31

@BatoolMM @alswajiab Please Review