Closed sandygudie closed 1 year ago
Name | Link |
---|---|
Latest commit | 3545a3ca14fb5eb58608705ab370b4f15a8d3719 |
Latest deploy log | https://app.netlify.com/sites/oscksa/deploys/6358cfc00f22770008a080fa |
Deploy Preview | https://deploy-preview-187--oscksa.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
@alswajiab @BatoolMM please review
This looks fantastic π·
Can you make the link for (More OSCSA events) open a new page on the website with all previous events?
This looks fantastic π·
Can you make the link for (More OSCSA events) open a new page on the website with all previous events?
Noted @BatoolMM
@sandygudie It looks fantastic, can you move this section to just before the UNESCO recommendation and resolve the conflict, please?
@sandygudie can you rebase this PR, please?
@sandygudie can you rebase this PR, please?
done @BatoolMM
@BatoolMM TypoError , "Materials" and the divider should be below the title text
@BatoolMM TypoError , "Materials" and the divider should be below the title text
Thank you for catching this!
@BatoolMM TypoError , "Materials" and the divider should be below the title text
Thank you for catching this!
i have fixed this
I made changes to the Arabic translation - The Materials in the nav bar should direct to the cards you created, can you fix that @sandygudie.
I made changes to the Arabic translation - The Materials in the nav bar should direct to the cards you created, can you fix that @sandygudie.
Alright, I will fix that right away
Thank you @sandygudie π· , for the speedy fix, I noticed that the Arabic page has no padding in all directions - the card reaches the end of the screen.
In terms of the English page, needs padding on the top and bottom only.
Can you fix this issue, I'd love to merge this today but no rush!
Thank you @sandygudie π· , for the speedy fix, I noticed that the Arabic page has no padding in all directions - the card reaches the end of the screen.
In terms of the English page, needs padding on the top and bottom only.
Can you fix this issue, I'd love to merge this today but no rush!
I will fix that now
Fantastic @sandygudie ! Isn't the card supposed to direct you to its page in Zenodo once it's clicked but that's not the case?
Fantastic @sandygudie ! Isn't the card supposed to direct you to its page in Zenodo once it's clicked but that's not the case?
Based on the Task description(Task 3) clicking on a card should open a more detailed subpage with description , to view slides or download etc https://github.com/Open-Science-Community-Saudi-Arabia/OSCSA_Website/issues/186
@sandygudie It would be nice for each card would direct you to a subpage - but this can be made in a separate PR - otherwise, this will be heavy PR. To merge this PR, it should at least direct you to the slides from Zenodo (their page in Zenodo), if that makes sense! Let me know if that's not clear!
@sandygudie if you need assistance with the subpages, i'm open to assist
Yes, thatβs right @BatoolMM,
@adetyaz is working on the subpages https://github.com/Open-Science-Community-Saudi-Arabia/OSCSA_Website/pull/191 @RealRichi3 feel free to collaborate with him
Looks fantastic, thank you again @sandygudie!
@sandygudie, the CSS for the Arabic page is completely distorted - can you open a PR to fix it, please?
Oh noπ, I had just pushed the fixed within the merging seconds, I will fix it quickly thanks
@BatoolMM the fix : https://github.com/Open-Science-Community-Saudi-Arabia/OSCSA_Website/pull/214
Summary: Issue https://github.com/Open-Science-Community-Saudi-Arabia/OSCSA_Website/issues/186
Tasks 3 We need to add an events subpage where we can link our events in Zenodo. 3.1 Add this to the nav bar PR. 3.2 Add three cards with each event, title, name of the speaker, and language.
Fixes
Event
link on the navbarWhat should a reviewer concentrate their feedback on?