Open-Science-Community-Saudi-Arabia / OSCSA_Website

The official website for the community
https://osc-ksa.com/
MIT License
13 stars 46 forks source link

[18/10/2022]Task3.2: Added event cards #187

Closed sandygudie closed 1 year ago

sandygudie commented 1 year ago

Summary: Issue https://github.com/Open-Science-Community-Saudi-Arabia/OSCSA_Website/issues/186

Tasks 3 We need to add an events subpage where we can link our events in Zenodo. 3.1 Add this to the nav bar PR. 3.2 Add three cards with each event, title, name of the speaker, and language.

Fixes

What should a reviewer concentrate their feedback on?

netlify[bot] commented 1 year ago

Deploy Preview for oscksa ready!

Name Link
Latest commit 3545a3ca14fb5eb58608705ab370b4f15a8d3719
Latest deploy log https://app.netlify.com/sites/oscksa/deploys/6358cfc00f22770008a080fa
Deploy Preview https://deploy-preview-187--oscksa.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sandygudie commented 1 year ago

@alswajiab @BatoolMM please review

BatoolMM commented 1 year ago

This looks fantastic 🌷

Can you make the link for (More OSCSA events) open a new page on the website with all previous events?

sandygudie commented 1 year ago

This looks fantastic 🌷

Can you make the link for (More OSCSA events) open a new page on the website with all previous events?

Noted @BatoolMM

BatoolMM commented 1 year ago

@sandygudie It looks fantastic, can you move this section to just before the UNESCO recommendation and resolve the conflict, please?

BatoolMM commented 1 year ago

@sandygudie can you rebase this PR, please?

sandygudie commented 1 year ago

@sandygudie can you rebase this PR, please?

done @BatoolMM

sandygudie commented 1 year ago

@BatoolMM TypoError , "Materials" image and the divider should be below the title text image

BatoolMM commented 1 year ago

@BatoolMM TypoError , "Materials" image and the divider should be below the title text image

Thank you for catching this!

sandygudie commented 1 year ago

@BatoolMM TypoError , "Materials" image and the divider should be below the title text image

Thank you for catching this!

i have fixed this

BatoolMM commented 1 year ago

I made changes to the Arabic translation - The Materials in the nav bar should direct to the cards you created, can you fix that @sandygudie.

sandygudie commented 1 year ago

I made changes to the Arabic translation - The Materials in the nav bar should direct to the cards you created, can you fix that @sandygudie.

Alright, I will fix that right away

BatoolMM commented 1 year ago

Thank you @sandygudie 🌷 , for the speedy fix, I noticed that the Arabic page has no padding in all directions - the card reaches the end of the screen.

Screenshot 2022-10-25 at 22 35 12

In terms of the English page, needs padding on the top and bottom only.

Screenshot 2022-10-25 at 22 35 43

Can you fix this issue, I'd love to merge this today but no rush!

sandygudie commented 1 year ago

Thank you @sandygudie 🌷 , for the speedy fix, I noticed that the Arabic page has no padding in all directions - the card reaches the end of the screen.

Screenshot 2022-10-25 at 22 35 12

In terms of the English page, needs padding on the top and bottom only.

Screenshot 2022-10-25 at 22 35 43

Can you fix this issue, I'd love to merge this today but no rush!

I will fix that now

BatoolMM commented 1 year ago

Fantastic @sandygudie ! Isn't the card supposed to direct you to its page in Zenodo once it's clicked but that's not the case?

sandygudie commented 1 year ago

Fantastic @sandygudie ! Isn't the card supposed to direct you to its page in Zenodo once it's clicked but that's not the case?

Based on the Task description(Task 3) clicking on a card should open a more detailed subpage with description , to view slides or download etc https://github.com/Open-Science-Community-Saudi-Arabia/OSCSA_Website/issues/186

BatoolMM commented 1 year ago

@sandygudie It would be nice for each card would direct you to a subpage - but this can be made in a separate PR - otherwise, this will be heavy PR. To merge this PR, it should at least direct you to the slides from Zenodo (their page in Zenodo), if that makes sense! Let me know if that's not clear!

RealRichi3 commented 1 year ago

@sandygudie if you need assistance with the subpages, i'm open to assist

sandygudie commented 1 year ago

Yes, that’s right @BatoolMM,

@adetyaz is working on the subpages https://github.com/Open-Science-Community-Saudi-Arabia/OSCSA_Website/pull/191 @RealRichi3 feel free to collaborate with him

BatoolMM commented 1 year ago

Looks fantastic, thank you again @sandygudie!

BatoolMM commented 1 year ago

@sandygudie, the CSS for the Arabic page is completely distorted - can you open a PR to fix it, please?

Screenshot 2022-10-26 at 08 20 24
sandygudie commented 1 year ago

Oh noπŸ˜‚, I had just pushed the fixed within the merging seconds, I will fix it quickly thanks

sandygudie commented 1 year ago

@BatoolMM the fix : https://github.com/Open-Science-Community-Saudi-Arabia/OSCSA_Website/pull/214