Open-Science-Community-Saudi-Arabia / OSCSA_Website

The official website for the community
https://osc-ksa.com/
MIT License
13 stars 46 forks source link

[24/10/2022] : fix social link icon display #205

Closed sandygudie closed 1 year ago

sandygudie commented 1 year ago

Summary

Issue: https://github.com/Open-Science-Community-Saudi-Arabia/OSCSA_Website/issues/204 In an attempt to improve page loading time, the preload attribute was added to the bootstraplink tag and this broke the social link icon displayed. However, since the bootstrap assets(icons, CSS, etc) are already downloaded into the project, this may not necessarily affect the page loading speed as opposed to using CDN which would be a perfect use for the preload attribute. This PR is a fix to this issue, I reverted the change made to the bootstrap Icons.

What should a reviewer concentrate their feedback on?

netlify[bot] commented 1 year ago

Deploy Preview for oscksa ready!

Name Link
Latest commit 453719eaf1ad11012a982a3a92175b21de27c9b5
Latest deploy log https://app.netlify.com/sites/oscksa/deploys/63623e82dd1bd900094c09cc
Deploy Preview https://deploy-preview-205--oscksa.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sandygudie commented 1 year ago

@BatoolMM @alswajiab Please review @anslemkelechi let me know if you think otherwise

sandygudie commented 1 year ago

@BatoolMM @alswajiab I noticed the hamburger menu icon for the mobile screen is no more visible on the home page , hence the nav links is not acessible, this is also due to the changes made to the bootstrap icon. image

The revert made in this PR would also fix that

sandygudie commented 1 year ago

@BatoolMM the PR to fix the social icon

BatoolMM commented 1 year ago

Ohhh, thank you 🙏