Closed sandygudie closed 1 year ago
Name | Link |
---|---|
Latest commit | 453719eaf1ad11012a982a3a92175b21de27c9b5 |
Latest deploy log | https://app.netlify.com/sites/oscksa/deploys/63623e82dd1bd900094c09cc |
Deploy Preview | https://deploy-preview-205--oscksa.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
@BatoolMM @alswajiab Please review @anslemkelechi let me know if you think otherwise
@BatoolMM @alswajiab I noticed the hamburger menu icon for the mobile screen is no more visible on the home page , hence the nav links is not acessible, this is also due to the changes made to the bootstrap icon.
The revert made in this PR would also fix that
@BatoolMM the PR to fix the social icon
Ohhh, thank you 🙏
Summary
Issue: https://github.com/Open-Science-Community-Saudi-Arabia/OSCSA_Website/issues/204 In an attempt to improve page loading time, the
preload
attribute was added to the bootstraplink
tag and this broke the social link icon displayed. However, since the bootstrap assets(icons, CSS, etc) are already downloaded into the project, this may not necessarily affect the page loading speed as opposed to using CDN which would be a perfect use for thepreload
attribute. This PR is a fix to this issue, I reverted the change made to the bootstrap Icons.What should a reviewer concentrate their feedback on?