Open-Science-Community-Saudi-Arabia / OSCSA_Website

The official website for the community
https://osc-ksa.com/
MIT License
13 stars 46 forks source link

[9/10/2022]: Refactor External Links on HomePage (index.html) #52

Open okerekechinweotito opened 2 years ago

okerekechinweotito commented 2 years ago

Corresponding PR Available at #53

Description ❔Ensure that External Links (<a href tags) on index.html direct to a new browser tab when clicked and carry a rel="noopener noreferrer" tag. 'noopener' is largely a security measure to prevent malicious links from gaining access to a user’s browser (a phishing attack known as tabnabbing 'noreferrer' keeps external sites from knowing that you have included links to their material on your website. This could be important to you for privacy or security reasons

Expected behavior

Actual behavior ❌ External links (a href='' ) on index.html overides and opens on the initial browser tab when clicked ❌ External links (a href='' ) do not carry rel="noopener noreferrer" flags which may lead to a security vulnerability

How to reproduce Go to https://osc-ksa.com/ Click on any External Link and observe the response

RealRichi3 commented 2 years ago

I would like to take this issue

okerekechinweotito commented 2 years ago

@RealRichi3 This issue has already been done. Kindly see the linked PR above

RealRichi3 commented 2 years ago

Oh alright then