Open-Shell / Open-Shell-Menu

Classic Shell Reborn.
MIT License
6.85k stars 428 forks source link

Classic Explorer status bar is light gray on Windows 10 1809 dark mode (Classic Explorer status bar and toolbar don't change to dark mode in Windows 10) #121

Open amartini opened 5 years ago

amartini commented 5 years ago

I'm using dark mode and everything seems right except for the status bar.

screenshot 14

blackcrack commented 5 years ago

go in the Configuration of Open-shell menu, All Programms Skin => select smoked Glass, this match so far or custom it more with custom coloring the menu.

imho can be closed this issue Because the Open-Shell Menu it is possible to configuring with custom colors .. isn't it @ge0rdi ?!

best regards Blacky

amartini commented 5 years ago

go in the Configuration of Open-shell menu, All Programms Skin => select smoked Glass, this match so far or custom it more with custom coloring the menu.

imho can be closed this issue Because the Open-Shell Menu it is possible to configuring with custom colors .. isn't it @ge0rdi ?!

best regards Blacky

Haven't changed for me. Besides i use windows 7 start menu, and smoked glass isn't available.

displayerror commented 5 years ago

I too have a light gray Status Bar after upgrading to the new Win10 1809 dark theme. I only install the "Classic Explorer" enhancements of Open-Shell (it's all I need as I use TrueLaunchBar/StartKiller etc. to handle the Start menu).

Am I still able to select this "Smoked Glass" skin/theme somewhere via .ini editing? Or do I have to install the "Open-Shell Menu" component just to get those settings? Actually, why does the "Open-Shell Menu" theme settings affect the "Classic Explorer" look?

blackcrack commented 5 years ago

on top => Show all settings screen 00000 screen 00002 screen 00003

ghost commented 5 years ago

I think there should just be an option for for explorer. Dark / white. And make the dark Match the color of dark explorer. You don't want it linked to the shell theme.

amartini commented 5 years ago

on top => Show all settings

This have nothing to do with my initial claim. I'm talking about the status bar on windows explorer windows, as you can see on the screenshot.

ghost commented 5 years ago

Didn't change anythinghing for me either the status bar remains white and even if it did work I don't want to use classic theme just for that.

NomDeMorte commented 5 years ago

This is a known bug in the dark mode of Explorer. This is a Microsoft bug, not an Open-Shell bug.

ge0rdi commented 5 years ago

This is a known bug in the dark mode of Explorer. This is a Microsoft bug, not an Open-Shell bug.

No. Status bar (that second one) is added/drawn by ClassicExplorer. We will need to fix ClassicExplorer so that it will use actual theme colors (for both status bar and toolbar).

Though for now I have no clue how to do it :(

ghost commented 5 years ago

Is the problem getting it to follow the skin color? Or can we not even compile a static dark version of the status bar?

amartini commented 5 years ago

Guys, i'm talking about the Status Bar on the Classic Explorer. This have nothing to do with task bar or start menu! The status bar is enabled with this setting: screenshot 47

ghost commented 5 years ago

I think their saying that there trying to link that statusbar color in explorer to the applied theme in start menu. Correct me if I'm wrong?

amartini commented 5 years ago

Well maybe it's indeed a windows bug. I see the status bar is created on ExplorerBHO.cpp line 1256:

m_Status8=CreateWindow(STATUSCLASSNAME,NULL,WS_CHILD|WS_VISIBLE|SBARS_SIZEGRIP|SBARS_TOOLTIPS,0,0,rc.right-rc.left,rc.bottom-rc.top,GetParent(status),NULL,g_Instance,NULL);

I don't see it painting the background anywhere, so maybe STATUSCLASSNAME is broken.

Hadden89 commented 5 years ago

Same with classic explorer toolbar. Still gray on dark (windows) theme, like the status bar. Guess is related to this explorer bug. (Open Shell menu works fine.) Background color for explorer toolbar/status bar shouldn't be linked to open shell theme (if possible) like said above. Even windows detail panel has this "light" issue and is almost useless on dark windows theme (in this case, is totally unrelated to open shell).

AkiraJkr commented 5 years ago

Can confirm this is a issue. Dark mode selected in Windows 10 and the Classic Explorer bars don't match Dark Mode.

EDIT: image

ghost commented 5 years ago

Still hoping for a fix

individuell commented 5 years ago

any fix for this?

NomDeMorte commented 5 years ago

This is a known bug in the dark mode of Explorer. This is a Microsoft bug, not an Open-Shell bug.

No. Status bar (that second one) is added/drawn by ClassicExplorer.

Ah I see now. This was an MS bug, so I was just accustomed to seeing a light status bar there, but MS's one is now fixed.

Ibuprophen commented 5 years ago

I'm working on getting the latest Windows 10 reinstalled on one of my Laptops again.

I was doing some playing around with a few things (testing stuff , trying out other stuff, etc... etc...) and Windows 10 threw a fit by giving me that well known BSOD style errors.

I've got 2 PC's and 3 Laptops (though I've got enough spare parts as well... LOL! ).

So now I've got the hard drive out of the laptop and performing some tests in my PC (as a precaution) then I've got to clean it up good as new.

Once that's done, I just pop it back in the Laptop and do some magic installing the latest Windows 10 build fresh as new.

I just love spares for Developments with Testing and such! I've even got a bunch of working Android's (and parts) for backups/developments of my App's and such.

When i get Windows 10 going, I'm going to see what I can do. I'm just not a big fan of Windows 10 myself but, I need to know it to help out here.

That's enough jabber/geek talk... LOL!

~Ibuprophen

ghost commented 5 years ago

Been watching this for a while. Im getting back into dev and will take a look too. Hopefully we get this fixed. I love dark windows with classic, better then any other UI out there and this will look so good all dark. Anyway back to trying to fix my graphics card and wifi and auto mounts working under another OS which is well know for its bugs. At least win is has proper plug and play. that's enough geek talk from me 2 lol

NomDeMorte commented 5 years ago

Possibly related, using the Vista style navigation pane the icons and scrollbar also seem to be effected.

blackcrack commented 5 years ago

a hint.. more Programmers, more fixes.. do you know WinNT Programmers, ask they are, if they want help .. also for the later WinNT like Reactos (it will comes in any case... and this for free for all under GPL) So ask around at known Programmers who you personally knows.. tell they are to be helping hand need here for patches and fixes..

best regards blacky

Ibuprophen commented 5 years ago

I used to work with WinNT but, haven't really had the need to for a while. Maybe I should get it going again.

Hmm... Maybe I can reparation the hard drive for a dual boot on my Windows 7 to add NT. Hmm...

~Ibuprophen

blackcrack commented 5 years ago

first boot harddisk win7 the 2nd harddisk with linux and bootloader.. this make i am loke so..

and have a 1TB harddisk as 3rd one who i store the things ..

and with bootmenu, like F12 or F9 or what ever can you call the boot menu out of the Bios, if's enabled ..

in Linux works Virtualbox also really pretty.. so, .. well.. all is possible..

Ibuprophen commented 5 years ago

I would just simplify it by Partitioning my 2TB Laptop HDD in half. The computer would see it as if it were 2 separate HDD's. This way 1 partition would have Windows 7 & the other with WinNT in it.

I would then create a dual boot menu so, when the Laptop boots up, there would be a menu to choose which one to boot into for 30 seconds to a minute (this is custom as it should be more than enough time to choose which one to select from). Of course, when the time period lapses, I would have a default OS pre-determined.

It looks more complicated than it really is. It's a simple, and effective, way to do this. I used to do this when I used to dual boot Unix/Linux about a zillion years ago... LOL!

~Ibuprophen

blackcrack commented 5 years ago

4 Primäre partitions, the first 2 for Win7 , one for WinNT, the 4th for Linux and Grub can maby managing all .. but if you reinstall kill Win7 your grub .. :\ so a bit heavy, but you could use grub4win https://sourceforge.net/projects/grub2win/.. oooorrr.. you use a usb-stick for boot, and install the linuxbootloader on the usb-stick, with them could you boot every your linux.. but you mus have the usb-stick ever at man..

well, the dualboot have i am also behind me ;) but a small ideen exchange is never bad :) :+1:

your Blacky *bg*

Ibuprophen commented 5 years ago

Ahhh... LOL!

I'm kinda familiar with what you're describing. I do believe that a friend of mine has a similar/same setup on his Alternate PC.

I have (legit ones of course) the Windows 7 Pro, 8.1 Pro, 10 Pro & NT on separate USB Thumb Drives.

Well... I own pretty much all the Microsoft Software stemming back to MS-DOS 3.1. I've still got all 25 Official (3.14") Floppies of Windows 95 too LMAO! :-P

For preparing the HDD partitions, I use the PartitionMagic Software and it's awesome too. I also use it because of the MicroSD's I prepare for the various Android devices I have.

For Creating Updated (Windows OS) USB Thumb Drives, I primarily use the Rufus Software. That's a great piece of Software that I even helped out with (once in a blue moon/on a few occasions) within its Github Repo.

I tend to stick with the tools I use as long as it works out for me. It's like that saying "don't fix what's not broken".

Before I had retired, some of the qualifications I held (as a requirement) was a handful of Microsoft Certifications and I'm actually current as a registered Microsoft OEM System Builder too.

There you go.... You pulled me into "jabbering mode"... LMAO! :-O

~Ibuprophen

individuell commented 5 years ago

I kind of found a fix/workaround for the issue. If you right click the bar and remove the checkmark it collapses to this small status bar which is more bearable.

image

GermanKiwi commented 5 years ago

I kind of found a fix/workaround for the issue. If you right click the bar and remove the checkmark it collapses to this small status bar which is more bearable.

From your screenshot I deduce you're referring to the Quick Access Toolbar, which appears above the ribbon in the top-left corner of the Explorer window, and which is a Windows/Microsoft feature.

However, in this thread we're discussing the Classic Explorer status bar, which appears along the bottom edge of the Explorer window and has nothing to do with the Quick Access Toolbar - they serve different purposes.

blackcrack commented 5 years ago

@individuell , should maybe check which Windows version running and then set it up to remove the checkboxes, or so.. so include you're fix/work around... Do you be a programmer ?

@Ibuprophen is this possible to add a Win NT-versions checker and add some scripts/code for the WinNT-Version (well, i am not a programmer, only a ooold 0X Dude) respective Windowsversion ? therewith could we service different WinNt versions.. winXP/Reactos, Win7, Win8 and 10 (in different versions, for bugfixes and workarounds)

... just so a idea .. *s*

Kiwi, du kannst auch nich coden ? patches and updates alway's welcome, right Ibu~ ? :)

best regards Blacky

Ibuprophen commented 5 years ago

@blackcrack, TBH, it's been quite some time since I've used WinNT and, when I did last, I never used Classic Shell on it (Yes, I stated Classic Shell because it's been that long).

Actually, I doubt that I would have really looked to use a Start Menu replacement software on the WinNT since, at the time, it had the Classic Start Menu already.

Regarding compatibility for WinNT, I wasn't aware of/had any knowledge of any issues with WinNT.

Do you know of any issues with (or does this software even support) WinNT @coddec, @ge0rdi & @XenHat?

Regarding WinXP & WinVista, I haven't used them in quite some time either (not as long as WinNT). I believe that, ultimately, WinVista is actually a pseudo version of Windows 7 anyways.

The Windows OS versions I typically have on my (test systems only) PC's/Laptop's are (the Professional versions of) Win7, Win 8.1 & Win10.

My primary system is Win8.1 Pro that's used for a bunch of stuff that I "typically" don't test on since it has software like Android Studio and other biggies. It's just pain stakingly long to have to redo my Primary Tower PC.

~Ibuprophen

flatline4400 commented 4 years ago

Any update on this? Failing something official, can we hack a resource somewhere to make the Classic Exporer Toolbar and the Status bar use a darker theme?

Turk303 commented 4 years ago

Whitebars - ability to set shade or colour would be so welcome Am I in the right place to keep an eye on possible updates in the ability to convert the white bars in the image I've posted to either shades or colours? If so (FINALLY) I found "you" :)

JohnEdwa commented 4 years ago

Unless Open-Shell changes the way it creates these bars, there is very little chance of it fixing it without Microsoft doing it for us. Enabling Dark mode changes the normal Explorer status bar, all the context menus, details panel and, if enabled, the old-style Command Bar as well, but what isn't changed is the "Menu Bar", which is what Open-Shell uses, and the only way to change that currently is with a custom visual style. darkribbon

Though that system is also used for the Task Manager which currently stays blindingly white, so there is a small chance MS might make the change. It is after all buried deep in the OS for the "High-Contrast" theme, and can be accessed by custom styles too.

Turk303 commented 4 years ago

Likely known by most here but just in case I thought I'd mention an app named QTTab does change the white bars colour, to,I believe to whatever shade is selected in Win 10's personalise control panel. Btw if you wish to over ride the restricted colours of win10's personalise options to a darker colour or full on black then WINAERO TWEAKER enables that and all kinds of tweaks n twiddles you may like - it appears to play nice with both Classic Shell AND QTTab installed.

More fyi : Just as classic shell is enabled/disabled, QTTab's options (enabled/disbaled & "theme's/actions) are also accessible via the same method of View/Options drop down in an open explorer window (as well its own opened app ui).

As said, all appears fine together with a glitch or 2 that is likely easily ironed out with the suitable set up choices but for now my icons are invisible due to QTTab making the white bar a black bar (as I want) but of course black icons are then invisible so I will be (when time allows) recreating the icons I've used so they are a light grey & thus my set up is usable (the image 2 above, which at the time of screen cap does have QTTab installed shows why I haven't used the 2 together for more than installation and basic tests. One of the glitches I mentioned was QTTab either "removed" the black texts below the icons or resized something, I'm certain resizing of font or ? will fix that - this is why I'm posting, to see if anyone else is up for checking it out.

I'll return, provide some successful pics and results or? when time permits.

Til then. L8rs

flatline4400 commented 4 years ago

Unless Open-Shell changes the way it creates these bars, there is very little chance of it fixing it without Microsoft doing it for us. Enabling Dark mode changes the normal Explorer status bar, all the context menus, details panel and, if enabled, the old-style Command Bar as well, but what isn't changed is the "Menu Bar", which is what Open-Shell uses, and the only way to change that currently is with a custom visual style.

The menu bar on my systems is black with white text while in dark mode (1909), regardless of classic shell being installed or not.

The color Open Shell picks for the background of the Classic Explorer Bar seems arbitrary, after a brief look at the code. There's no reason why it couldn't pick it from a different Windows setting or, even better, a custom setting that's part of Open Shell itself. It's just another custom toolbar, and they can look like whatever you want. I'd try to fiddle with it myself but I've never tried to compile a big project like this before and I'm sure it would be hours before I got it to go, if ever. The Status Bar may be a different beast, I haven't looked at that part.

JohnEdwa commented 4 years ago

The menu bar on my systems is black with white text while in dark mode (1909), regardless of classic shell being installed or not.

The old "File Edit View Tool" menu bar that Classic Shell uses for its icons as well? Because if so, then that was fixed by Microsoft in 1909 - the image above is from 1803 where that menu follows the old "Classic" visual style colours that stay light even with dark mode. I can't test it because for me that menu bar is now actually black on black as I have QTtabBar taking over the skinning for it.

Jevnaker commented 4 years ago

Not sure if this is the right place to put this, but i recently upgraded my laptop to windows 10 from windows 7 and installed open shell ofc. But with the same settings in terms of skin and start menu style i get different colour on my laptop than i do on my desktop with the same settings in the options for openshell. also on my laptop only the clock part of my taskbar was changed to white colour when i changed the colour of it. The only difference is that my desktop uses an older version of openshell. How can i get the laptop version of my openshell to match my desktop one when i get different colours on the two with the same openshell skin settings.

jabcreations commented 4 years ago

Fix, kind of...

You'll need to get a copy of WindowBlinds (not free and it must always be running though not a terrible resource-hog) and then use this free theme: https://www.wincustomize.com/explore/windowblinds/8824

Unfortunately besides that WindowBlinds is NOT free this theme (the only one on the entire website since I last checked ~June 2020) this is the only theme to actually do an actual dark mode.

BUT it adds a dumb pointless button the simply collapses a window. It messes with the window controls for Waterfox making them useless.

There is an editor for *.WBA files and I have faintly found the reference to that damned fourth button. However I simply do not have the time to tinker until death.

Since I was kind enough to post this much maybe someone will be kind enough to dig in to the WBA editor, fix this theme and post the working file for everyone.

itsdoreiku commented 3 years ago

Still waiting on a real fix for this and not an extra 3rd party thing.

Turk303 commented 3 years ago

Not sure if this is the right place to put this, but i recently upgraded my laptop to windows 10 from windows 7 and installed open shell ofc. But with the same settings in terms of skin and start menu style i get different colour on my laptop than i do on my desktop with the same settings in the options for openshell. also on my laptop only the clock part of my taskbar was changed to white colour when i changed the colour of it. The only difference is that my desktop uses an older version of openshell. How can i get the laptop version of my openshell to match my desktop one when i get different colours on the two with the same openshell skin settings.

See my mention above re WINAERO

in short: you may simply have different colours set in the "Personalisation / Colours" settings - see if matching those helps

As said above, winaero enables (allows you to select) actual BLACK should it be wanted, which MS disallows. [why? who knows].

They sacked half+ of their Win10 dev team a few years back (for some juicy inside info see you tube channel "Barnacules Nerdgasm" an ex miscrosoft team employee who despite having an exemplary record at microsoft, as many of his colleagues, "won" the chopped lottery when ms downsized despite windows 10 shall we say not being in a perfect ideal state when shoved out the door on us, for politeness sake. He also dropped long before most knew the Win 7 was no longer being update after the end of this year - alas his channel, due to ill health, has less videos of late but there's enough already there of great interest.

Turk303 commented 3 years ago

Fix, kind of...

You'll need to get a copy of WindowBlinds (not free and it must always be running though not a terrible resource-hog) and then use this free theme: https://www.wincustomize.com/explore/windowblinds/8824

Unfortunately besides that WindowBlinds is NOT free this theme (the only one on the entire website since I last checked ~June 2020) this is the only theme to actually do an actual dark mode.

BUT it adds a dumb pointless button the simply collapses a window. It messes with the window controls for Waterfox making them useless.

There is an editor for *.WBA files and I have faintly found the reference to that damned fourth button. However I simply do not have the time to tinker until death.

Since I was kind enough to post this much maybe someone will be kind enough to dig in to the WBA editor, fix this theme and post the working file for everyone.

  • Edit 1: this does not properly work with the Task Manager which is really obnoxious to me.
  • Edit 2: theming in Windows is a disaster since there is not much consistency. You can use WindowBlinds to edit themes though with a few hours I haven't had the success I've sought. Still, this should get most folks a bit further ahead.

I happen to have a cough "copy" of Windowsblinds and did semi succesfully tweak an existing theme but felt it may have introduced some mild instability (lets face it we dont need any more as windows 10 stands) & for the benefit of white to black seemed offset by the additional resources used.

We'll get there - i'm sure - maybe someone like nirsoft or sordum org will grow a clone of themselves and set them to task... they appear quite busy as is. :P

ThumpieBunnyEve commented 3 years ago

bump.

jean3x7 commented 3 years ago

Any way to fix it? workaround?

jabcreations commented 3 years ago

You guys know developers accept money, right? Like, they have bills to pay and 99.999% of the people they talk with can't or won't give them money while saying, "gimme gimme gimme!" If I really wanted this fixed I'd offer the main developer $100+. Most code is atrocious, so working on code to deal with someone else's code takes ridiculous amounts of time. Developers have lives, family and friends too so the best thing someone could do is start some sort of tip-jar and allow people to add a few bucks that get deducted / paid to the developer when the problem is fixed. No one here might be able to drop $100 or more to fix this problem though there certainly are a lot of people who could chip in $5.

blackcrack commented 3 years ago

what do you think why Inkscape not really come in front, i have posted at they are a suggestion for autorun batch commands the switch yes for make default actions "-y" to have a possibility for let automatic png's move into svg's , one of them developer had take me away from the normal issue post and told me the idea is grate .. he want do into.. and behind a couple posts who have he make more hot to make integrate it into this f.. b.. switch told he to me, i have to make a payment for supporting this... and the issue was disappear in the normal issue list.. and something do i am not supporting.. look Gimp, could be Gimp so far if they kidnaps users to say them, first a Champaign shower then the enhancement.. at this point raise i my middle finger ... we are here not on a shop.. a Donation page is really well for support the supporting, but explicit mulct/extort for supporting something.. oohh man.. not with me.. this was at inkscape.. so i raised the finger .. And 100$ helps me over 2 weeks for eat.. And a Donation-page helps to give money and this Developer who makes more issues, becomes more from the money, this is the right way, but not a extort at any single users.. Therewith could you better advise if you consult a Donation page for Open-Shell to help the Developer for make his own money if they do something... and not push the blame to the users and stay offtopic ...

best regards

jabcreations commented 3 years ago

This directory: C:\Windows\Resources\Themes\aero

Contains *.msstyles files.

There are a TON of options and no doubt one of them can be edited to address this issue.

Unfortunately the program said that Windows rejected the theme though perhaps someone with some patience may want to try and edit an existing Aero theme?

Here is the binary to edit *.msstyles files: https://github.com/nptr/msstyleEditor/releases

jedikalimero commented 2 years ago

Still not a fix for this issue? Also, someone should change the topic to something like: "Classic Explorer status bar and toolbar don't change to dark mode in Windows 10"

MilesFarber commented 2 years ago

You know i wouldn't mind the fact that this issue is still present if it wasn't for the fact that I don't need 2 status bars...

blackcrack commented 2 years ago

You know i wouldn't mind the fact that this issue is still present if it wasn't for the fact that YOU CANNOT DISABLE THE STATUS BAR. WHO THE F---- NEEDS TWO F------- STATUS BARS?????

you know, who scream and have a behave like an douchebag, have rarely right ...

and the best, any laugh about ;) because the moderator have the right, your posting to delete ;)