search

Open-Shell / Open-Shell-Menu

Classic Shell Reborn.
MIT License
6.86k stars 428 forks source link

Missing Icons for disconnected drives #1344

Open Hiche3 opened 1 year ago

Hiche3 commented 1 year ago

Describe the bug

Icons are missing from start menu when a shortcut points to source that was disconnected during boot up. Icons are not restored even if the source is later connected (and successfully started from start menu). Icons used to show when shortcut was initially added to start menu.

It appears that the start menu icons are checked during startup. Perhaps keep the cached icons if the shortcut is broken and hence icon cannot be fetched.

Edit: Even though the shortcut icon is still missing from Start > All Programs, the icon is showing in the main "Start" menu, which displays frequently used programs.

Area of issue

Start menu

To reproduce

  1. Create shortcut
  2. Verify that icon is showing in start menu
  3. Rename program's folder name (to simulate detached source)
  4. Restart computer
  5. Restore program's folder name (changed in step 3)
  6. Notice that Icon remains blank

Expected behavior

Don't replace previously cached icons if shortcut is broken.

Open-Shell version

4.4.170

Windows version

22H2

Additional context

No response

Hiche3 commented 1 year ago

Edit: Even though the shortcut icon is still missing from Start > All Programs, the icon shows in the main "Start" menu, which displays frequently used programs.