Open-Shell / Open-Shell-Menu

Classic Shell Reborn.
MIT License
6.88k stars 427 forks source link

Update issues: error message, CSM not running afterward #1651

Open mzso opened 1 year ago

mzso commented 1 year ago

Describe the bug

I think one part of it is a bug, the other just annoying. During the setup I got this apparently bogus error: kép

Later on, I got prompted for the very same file for elevated rights, so it couldn't have failed.

The second part is an old thing. The installer closes the classic start menu and when it finishes I end up with the windows default. Which is more cumbersome then ever, I had to open some collapsed applications section, to find open shell menu settings. The opening of which got CSM running

Area of issue

Installation/Other

To reproduce

  1. Install app
  2. observe the noted issues

Expected behavior

No errors of failing to extract a file, especially since apparently it succeeded.

The installer starting Classic Start Menu, so I won't have to dig around in Windows' start menu which I haven't used in years.

Open-Shell version

4.4.190

Windows version

Win10 22H2

Additional context

No response

ge0rdi commented 1 year ago

Later on, I got prompted for the very same file for elevated rights, so it couldn't have failed.

According to code, such error is reported when installer is unable to create file (mentioned in the message) and thus it doesn't write any data to it. Moreover installer will end on this error.

I'd say you must have run installer again (after the first failure) and then it just succeeded.

The installer closes the classic start menu and when it finishes I end up with the windows default.

The installer is supposed to start Open-Shell menu after install/upgrade. It definitely works (otherwise we will have tons of such reports). So really hard to tell why it didn't work in your case.

If you want to help to investigate the issue, then please do following:

mzso commented 1 year ago

@ge0rdi I didn't run the installer again. I didn't need to, it succeeded despite the error.

Is the starting of Open Shell menu a new thing? Because I don't remember it every working. At least I had to start it a number of times during the original classic shell as well.

ge0rdi commented 1 year ago

Is the starting of Open Shell menu a new thing?

Nope.

It was always supposed to start automatically. After installation you should have Open-Shell start menu available right away.

I have not seen any issue with that personally. Possibly there is something on your machine interfering? If you could replicate and provide the install log maybe that will shed some light on it.