search

Open-Shell / Open-Shell-Menu

Classic Shell Reborn.
MIT License
6.93k stars 431 forks source link

Some Windows app icons fail to load #1667

Open Hiche3 opened 1 year ago

Hiche3 commented 1 year ago

Describe the bug

See https://github.com/Open-Shell/Open-Shell-Menu/issues/1339

Same issue, with the exact same icons showing (and not showing) when typing in "features", after upgrading from 4.4.170 to 4.4.190.

The icons do show when using Window's original start menu.

I cleared windows icon cache and repaired Open Shell, made no difference.

I then deleted %LOCALAPPDATA%\OpenShell\DataCache.db and ran the installer again without uninstalling (just clicking all the way through), and that fixed the issue.

Area of issue

Start menu

To reproduce

open the startmenu type "features" some icons don't load.

Expected behavior

No response

Open-Shell version

4.4.190

Windows version

Windows 10 22H2

Additional context

No response

ge0rdi commented 1 year ago

Please, attach a screenshot that shows what icons are missing.

I cleared windows icon cache and repaired Open Shell, made no difference.

Could you try Open-Shell settings -> Backup -> Clear cached information?

Hiche3 commented 1 year ago

Could you try Open-Shell settings -> Backup -> Clear cached information?

I actually tried that while troubleshooting, and it made no difference.

As mentioned earlier, what did work was deleting %LOCALAPPDATA%\OpenShell\DataCache.db and running the installer again, without uninstalling, and just clicking all the way through.

ge0rdi commented 1 year ago

I actually tried that while troubleshooting, and it made no difference.

Clearing cache deletes DataCache.db among other things.

running the installer again

Installer doesn't touch any data. Though it may have restarted Explorer. Maybe that fixed those icons?

Are you able to replicate this issue? If so, then please provide screenshot that will show what icons are actually missing. Also try to restart Explorer (or Clear cache + restart Explorer) to see if it makes difference.

Hiche3 commented 1 year ago

I ran the following script to rebuild the icon cache, including restarting the computer: https://www.tenforums.com/tutorials/5645-rebuild-icon-cache-windows-10-a.html

That didn't fix it.

The missing icons mirrored the screenshot posted here when typing in "features": https://github.com/Open-Shell/Open-Shell-Menu/issues/1339

https://user-images.githubusercontent.com/5408749/221431290-c9ac70a5-d57d-41fc-b637-ded958383ef7.png

After running the installer, DataCache.db was re-created (since I had deleted it). All icons appeared immediately after.

ge0rdi commented 1 year ago

The missing icons mirrored the screenshot posted here when typing in "features"

So the problem is with icons in Settings section. Those are modern settings that we enumerate in our own shell extension. We are generating those icons, so I don't have clue why some should work fine and some don't. It looks to me like they are cached somewhere and explorer has some trouble retrieving them and thus use default icon instead of asking us for the actual icon.

After running the installer, DataCache.db was re-created (since I had deleted it). All icons appeared immediately after.

Clear cached information should do the same. So I don't quite get how the installer helps here.

Ok. Are you able to replicate the issue?

Sam-Hall commented 6 months ago

I have one shortcut with this broken icon problem in the Open Shell start menu for Windows Terminal which lives in %appdata%\Microsoft\Windows\Start Menu. I've tried to give it the CMD icon by using the icon in imageres.dll and by using cmd.exe. Looking at the shortcut in "Start Menu" folder directly, you can see the correct icon is set. I've tried clearing the icon cache including the explorer db files, but nothing fixes it. I've not tried re-installing yet. Windows Terminal is a UWP, I'm not sure if that has anything to do with it.

cason-wu commented 4 months ago

My issue is that the disappearing icons are only for UWP apps. image

ge0rdi commented 4 months ago

Try to run Shell:AppsFolder. It will open folder with all applications. Can you see icons there for applications you mentioned above (Calculator, Snipping Tool, ...) ?

cason-wu commented 4 months ago

There are duplicate items for apps pinned to the Start menu.

image image image

ge0rdi commented 4 months ago

Can you provide log obtained using this guide?

cason-wu commented 4 months ago

After using "Unpin from Start menu (Open-Shell)" and then "Pin to Start menu (Open-Shell)" and rebooting, all the icons returned to normal. However, after installing a new program and rebooting, the Snipping Tool icon had issues again, but this time it wasn't blank. The icons in the Apps folder were completely fine.

image image

StartMenuLog.txt