search

Open-Shell / Open-Shell-Menu

Classic Shell Reborn.
MIT License
7.01k stars 433 forks source link

40px large Start buttons are misaligned by one pixel #1726

Open RoozerXC opened 1 year ago

RoozerXC commented 1 year ago

Describe the bug

This issue is evident on Windows 10 when using my black-and-color pack, along with other start buttons that have borders on them image On my retro gaming machine running Windows 7 Ultimate SP1, build 7601 the start button perfectly lines up with the taskbar image

Area of issue

Taskbar

To reproduce

  1. System must be running on Windows 10 or newer
  2. Taskbar must be set to use large icons with 100% dpi
  3. Use a 40x120 or 120x120 start button texture matching along with the taskbar (black-and-color)
  4. Apply

Expected behavior

See the Windows 7 screenshot

Open-Shell version

4.4.191

Windows version

Windows 10 Pro 22H2, 19045.3324

Additional context

The textures are all the same width and height (40px) which is supposed to be the exact same size as the original taskbar. Doing a little bit of research on the original classic shell forums suggest that this is a problem that probably has never been fixed for many years. Kinda bugs me a little when stuff like the start button is misaligned with the taskbar. What is going on here?

ge0rdi commented 1 year ago

Could you provide your configuration XML?

This is from clean installation of Open-Shell 4.4.191 in Windows 10 sandbox: image

It looks good to me. I have just set custom start button image (start-blue-large-40px.png) and custom taskbar texture (taskbar-blue-large-40px.png).

RoozerXC commented 1 year ago

Could you provide your configuration XML?

This is from clean installation of Open-Shell 4.4.191 in Windows 10 sandbox: image

It looks good to me. I have just set custom start button image (start-blue-large-40px.png) and custom taskbar texture (taskbar-blue-large-40px.png).

Sure, here is the xml Menu Settings.zip

Also I forgot to mention it uses the WIN7LIKE COMBO revC skin so i'll link that here as well http://www.classicshell.net/forum/viewtopic.php?f=17&t=5824

RoozerXC commented 1 year ago

I realized I made a typo on the version number (5.4.191) so it should be fixed now

I also crafted a workaround which fixes the issue, but I still have no idea why the start button doesn't align itself properly image image I can only guess one or some of my installed apps or services are causing the issue? I don't really know, though i could try running in clean (or safe) mode and see if the issue still persists

ge0rdi commented 1 year ago

I'm unable to reproduce the issue. I have used your XML, images and also skin (even though skin doesn't affect taskbar customizations).

Though I've noticed that on your first screenshot the taskbar is 39px high, instead of 40px (as one would expect). So I think there is something on your system that interferes with your taskbar. Open-Shell is not supposed to change dimensions of taskbar.

Do you use any other customization software (like ExplorerPatcher)?

git24hub commented 1 year ago

Start button works never. No matter how small or big. It is always cut halfway through windows-icon-png-5824

ge0rdi commented 1 year ago

@git24hub This is unrelated to current issue (1px misaligned start button).

Please, for the future create separate issue/discussion for unrelated things. Have you tried Align to corner of the screen option?

git24hub commented 1 year ago

@git24hub This is unrelated to current issue (1px misaligned start button).

Please, for the future create separate issue/discussion for unrelated things. Have you tried Align to corner of the screen option?

Yes I have. The same issue

ge0rdi commented 1 year ago

@git24hub Then, please create separate issue/discussion with description of your problem along with all the relevant information (version of Open-Shell, Windows, settings you are using, start button image, etc.

RoozerXC commented 1 year ago

I'm unable to reproduce the issue. I have used your XML, images and also skin (even though skin doesn't affect taskbar customizations).

Though I've noticed that on your first screenshot the taskbar is 39px high, instead of 40px (as one would expect). So I think there is something on your system that interferes with your taskbar. Open-Shell is not supposed to change dimensions of taskbar.

Do you use any other customization software (like ExplorerPatcher)?

Sorry for the late response @ge0rdi, I was busy tinkering with old tech while also dealing with other mental health issues that have been going on in my life lately. I use 7+ Taskbar Tweaker, and nothing else. I do not use any other modifications to Windows Explorer.

I believe my snipping tool did not capture the taskbar as i expected it to, so its a mistake in the screenshot. I took a new screenshot of my pc just now and cropped it in paint.net so you can actually see its proper height (which should be 40px)

image

I tried closing 7+ Taskbar Tweaker and trying the 40px taskbar in Safe Mode. Nothing so far and the button is still misaligned by 1 pixel, so as a last resort maybe I could either try it on a virtual machine, or swapping SSDs and see if I could get a different result with the same version of Windows that I'm currently using right now.

ge0rdi commented 1 year ago

I tried closing 7+ Taskbar Tweaker and trying the 40px taskbar in Safe Mode.

Could you try to temporarily uninstall 7+ Taskbar Tweaker to make sure it is not interfering?

RoozerXC commented 1 year ago

Tried uninstalling it. Still the same thing.

image

I did reinstall Windows in a virtual machine and weirdly it actually looks normal, so I'm quite sure that something is interfering with my start button and I still have no idea what program is doing so.

image

I'm almost close to giving up anyway, since I couldn't find what program is really causing my start button to align vertically down by 1 pixel, and looking this issue up on Google never really seems to help either.