search

Open-Shell / Open-Shell-Menu

Classic Shell Reborn.
MIT License
6.59k stars 417 forks source link

Update en-US.csv (illegal "" in the file) #1792

Closed Need74 closed 6 months ago

Need74 commented 6 months ago

Just modify the illegal quot ""

AppVeyorBot commented 6 months ago

:white_check_mark: Build Open-Shell-Menu 4.4.192-xuacmxvn completed (commit https://github.com/Open-Shell/Open-Shell-Menu/commit/7346a93ad8 by @Need74)

ge0rdi commented 6 months ago

Why would double quotes be illegal here? File uses tab character (0x09) as column separator. So any quotes in strings are perfectly valid.

Moreover this file is generated on build from actual resource strings in binaries: https://github.com/Open-Shell/Open-Shell-Menu/blob/master/Src/Setup/BuildBinaries.bat#L28

Not sure why it is even stored in git as it is not accurate (doesn't contain all the strings). Plus we don't really support localization of settings dialogs at the moment (see https://github.com/Open-Shell/Open-Shell-Menu/issues/280).

So I don't think this modification is needed at all.

Need74 commented 6 months ago

Hi sorry for the mistake but I was looking for the original texts in English to translate them into French and I came across this one where Github indicated the following comment: "We can make this file beautiful and searchable if this error is corrected: Illegal quoting in line 45." On the page : https://github.com/Open-Shell/Open-Shell-Menu/blob/master/Src/Localization/English/en-US.csv I was a little hasty in correcting it, thinking I was doing the right thing.

Greetings

ge0rdi commented 6 months ago

Oki, no problem.