Open-Shell / Open-Shell-Menu

Classic Shell Reborn.
MIT License
7.04k stars 431 forks source link

When using a graphics tablet it won't open! #1939

Open Rcipolletta opened 5 months ago

Rcipolletta commented 5 months ago

Describe the bug

If i'm using my graphics tablet / drawing tablets / pen (not a native english speaker, sorry, i don't know how to call it) the classic shell menu won't open. The windows 11 start menu will open instead

image

Area of issue

Start menu

To reproduce

1) click on a start button with a pen / graphics tablet

Expected behavior

No response

Open-Shell version

4.4.191

Windows version

23H2

Additional context

No response

Ibuprophen commented 5 months ago

Unfortunately, Wacom Tablets use Android based software.

There's currently a feature request #553 for supporting such devices.

Sorry for the bad news... 😢

~Ibuprophen

ge0rdi commented 5 months ago

If i'm using my graphics tablet / drawing tablets / pen (not a native english speaker, sorry, i don't know how to call it) the classic shell menu won't open.

I believe this is the same issue as with touch enabled devices. We are simply unable to intercept touch events at the moment :( It was reported in #1229.

There's currently a feature request https://github.com/Open-Shell/Open-Shell-Menu/issues/553 for supporting such devices.

That ticket is about running Open-Shell on ARM-based devices. That's not quite related to pointing devices such as graphics tablet.

Rcipolletta commented 5 months ago

Two info that could be useful: -On windows 10 i had a TECLAST touch screen computer and classic shell was working, -not a coding expert here, but what if you just add a line that just opens classic shell whenever windows start menu tries to pop out? we would lose the opportunity to open start menu but who uses it anymore AND we could just end classic shell if we ever need to

ge0rdi commented 5 months ago

On windows 10 i had a TECLAST touch screen computer and classic shell was working

The problem is only with recent Win11 because they use completely different framework (XAML) for taskbar/start menu.

not a coding expert here, but what if you just add a line that just opens classic shell whenever windows start menu tries to pop out?

This is what Open-Shell is doing. It hooks keyboard/mouse input and when there is Win key or Start button pressed, it reacts on the event first (by displaying own start menu). Unfortunately, we are unable to hook touch events on Win11, thus we don't know when Start button is clicked.

The only workaround at the moment is to use custom start button (Replace start button option). Our Aero button should work out-of-the-box on Win11.

Rcipolletta commented 5 months ago

Hope this could help (sorry if it's just a loss of time), but for some reason if i replace the windows 11 start button and then i go back to the original windows start button by unchecking the box, classic shell will open up correctly when i click on start with my tablet it's a XP-PEN if that can help (the image i posted was just for reference because i didn't know its english name)

ghost commented 1 month ago

The only workaround at the moment is to use custom start button (Replace start button option). Our Aero button should work out-of-the-box on Win11.

Couldn't be a solution to add a "transparent" button?

ge0rdi commented 1 month ago

Fully transparent windows don't receive input events. So that won't help.

Though you can create custom button that is almost transparent. This would then appear like there is no custom button and you will see original Windows button underneath.

ghost commented 1 month ago

Though you can create custom button that is almost transparent.

Wouldn't this make the windows key a little muddy? Anyway, Im gonna try this when I get home and let you know (if you have no touch device for testing)

ghost commented 1 month ago

All right, i got some news about this, seems like using an image (almost transparent #01000000) as suggested worked, but on default setting it wasn't really aligned, i used this image: https://github.com/user-attachments/assets/1a38d362-7eaf-4700-b95f-be610b17ef85 And used this settings (Button size might vary based on device resolution and taskbar size?) image

Here it is a video of it in action (video is speed-up and low quality for size reasons) https://github.com/user-attachments/assets/74378201-d00d-4b4e-b095-fe40eb0b0db4

Should this be the definitive solution to this problem? If so, i think there should be a toggle or something that makes this process automatic